Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2284093002:
Accelerometer: find trigger name (Closed)
DescriptionAccelerometer: find trigger name
Do not assume the sysfs trigger to use is trigger0. Instead find the
trigger which name is "sysfstrig0". This is the name used by
accelerometer-init.sh udev script.
BUG=chromium:632486
TEST=With proper accelerometer-init.sh, check that chrome rotate screen
even when cros-ec-ring driver is loaded.
NOTRY=true
NOPRESUBMIT=true
TBR=oshima@chromium.org
R=jonross@chromium.org
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>;
Review-Url: https://codereview.chromium.org/2198543002
Cr-Commit-Position: refs/heads/master@{#410407}
(cherry picked from commit 1ade62df9003dc43cc47037d8207a2a6b89c3014)
Patch Set 1 #
Messages
Total messages: 17 (9 generated)
Description was changed from ========== Accelerometer: find trigger name Do not assume the sysfs trigger to use is trigger0. Instead find the trigger which name is "sysfstrig0". This is the name used by accelerometer-init.sh udev script. BUG=chromium:632486 TEST=With proper accelerometer-init.sh, check that chrome rotate screen even when cros-ec-ring driver is loaded. R=jonross@chromium.org Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Review-Url: https://codereview.chromium.org/2198543002 Cr-Commit-Position: refs/heads/master@{#410407} (cherry picked from commit 1ade62df9003dc43cc47037d8207a2a6b89c3014) ========== to ========== Accelerometer: find trigger name Do not assume the sysfs trigger to use is trigger0. Instead find the trigger which name is "sysfstrig0". This is the name used by accelerometer-init.sh udev script. BUG=chromium:632486 TEST=With proper accelerometer-init.sh, check that chrome rotate screen even when cros-ec-ring driver is loaded. NOTRY=true NOPRESUBMIT=true R=jonross@chromium.org Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Review-Url: https://codereview.chromium.org/2198543002 Cr-Commit-Position: refs/heads/master@{#410407} (cherry picked from commit 1ade62df9003dc43cc47037d8207a2a6b89c3014) ==========
gwendal@chromium.org changed reviewers: + oshima@chromium.org
Description was changed from ========== Accelerometer: find trigger name Do not assume the sysfs trigger to use is trigger0. Instead find the trigger which name is "sysfstrig0". This is the name used by accelerometer-init.sh udev script. BUG=chromium:632486 TEST=With proper accelerometer-init.sh, check that chrome rotate screen even when cros-ec-ring driver is loaded. NOTRY=true NOPRESUBMIT=true R=jonross@chromium.org Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Review-Url: https://codereview.chromium.org/2198543002 Cr-Commit-Position: refs/heads/master@{#410407} (cherry picked from commit 1ade62df9003dc43cc47037d8207a2a6b89c3014) ========== to ========== Accelerometer: find trigger name Do not assume the sysfs trigger to use is trigger0. Instead find the trigger which name is "sysfstrig0". This is the name used by accelerometer-init.sh udev script. BUG=chromium:632486 TEST=With proper accelerometer-init.sh, check that chrome rotate screen even when cros-ec-ring driver is loaded. NOTRY=true NOPRESUBMIT=true TBR=oshima@chromium.org R=jonross@chromium.org Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Review-Url: https://codereview.chromium.org/2198543002 Cr-Commit-Position: refs/heads/master@{#410407} (cherry picked from commit 1ade62df9003dc43cc47037d8207a2a6b89c3014) ==========
The CQ bit was checked by gwendal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
On 2016/08/26 23:59:17, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. lgtm
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Accelerometer: find trigger name Do not assume the sysfs trigger to use is trigger0. Instead find the trigger which name is "sysfstrig0". This is the name used by accelerometer-init.sh udev script. BUG=chromium:632486 TEST=With proper accelerometer-init.sh, check that chrome rotate screen even when cros-ec-ring driver is loaded. NOTRY=true NOPRESUBMIT=true TBR=oshima@chromium.org R=jonross@chromium.org Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Review-Url: https://codereview.chromium.org/2198543002 Cr-Commit-Position: refs/heads/master@{#410407} (cherry picked from commit 1ade62df9003dc43cc47037d8207a2a6b89c3014) ========== to ========== Accelerometer: find trigger name Do not assume the sysfs trigger to use is trigger0. Instead find the trigger which name is "sysfstrig0". This is the name used by accelerometer-init.sh udev script. BUG=chromium:632486 TEST=With proper accelerometer-init.sh, check that chrome rotate screen even when cros-ec-ring driver is loaded. NOTRY=true NOPRESUBMIT=true TBR=oshima@chromium.org R=jonross@chromium.org Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Review-Url: https://codereview.chromium.org/2198543002 Cr-Commit-Position: refs/heads/master@{#410407} (cherry picked from commit 1ade62df9003dc43cc47037d8207a2a6b89c3014) ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
