third_party/libtiff/tif_aux.c - Issue 2284063002: Fix for #618267. Adding a method to determine if multiplication has

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libtiff/tif_aux.c

Issue 2284063002: Fix for #618267. Adding a method to determine if multiplication has (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libtiff/tif_aux.c

diff --git a/third_party/libtiff/tif_aux.c b/third_party/libtiff/tif_aux.c

index 927150a49352deaf881631a3abd6e00e09887993..3613fbae2b73ce47d9b75bbaed18c336316633f0 100644

--- a/third_party/libtiff/tif_aux.c

+++ b/third_party/libtiff/tif_aux.c

@@ -69,7 +69,7 @@ _TIFFCheckRealloc(TIFF* tif, void* buffer,

* XXX: Check for integer overflow.

- if (nmemb && elem_size && bytes / elem_size == nmemb)

+ if (nmemb && elem_size && _TIFFIfMultiplicationOverflow(nmemb, elem_size))//&& bytes / elem_size == nmemb

Tom Sepez 2016/08/26 23:05:28 remove the code following the //

cp = _TIFFrealloc(buffer, bytes);

if (cp == NULL) {