Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2284033002: Update UsbChooserController unit test (Closed)

Created:
4 years, 3 months ago by juncai
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update UsbChooserController unit test This CL added a MockUsbChooserView to test the UsbChooserController. BUG=637402 Committed: https://crrev.com/3c1b74d2cec9fc150eef16be9ddfc122e656bba0 Cr-Commit-Position: refs/heads/master@{#414915}

Patch Set 1 : updated UsbChooserController unit test #

Patch Set 2 : removed defaulted destructor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M chrome/browser/usb/usb_chooser_controller_unittest.cc View 1 7 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
juncai
Please take a look.
4 years, 3 months ago (2016-08-26 21:41:07 UTC) #4
Reilly Grant (use Gerrit)
lgtm
4 years, 3 months ago (2016-08-26 21:45:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284033002/20001
4 years, 3 months ago (2016-08-27 02:07:20 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-27 11:00:42 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-27 11:04:19 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3c1b74d2cec9fc150eef16be9ddfc122e656bba0
Cr-Commit-Position: refs/heads/master@{#414915}

Powered by Google App Engine
This is Rietveld 408576698