Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Unified Diff: Source/wtf/VectorTest.cpp

Issue 228403002: Deque: Add HeapDeque and prevent buggy use of swap and operator= (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix Ians nit Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/wtf/Vector.h ('k') | Source/wtf/wtf.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/wtf/VectorTest.cpp
diff --git a/Source/wtf/VectorTest.cpp b/Source/wtf/VectorTest.cpp
index 2f279027781b1e238e12f9fefc7f02c541c804aa..05c0edc32335f0b1974ab32009a8b4a820fd0714 100644
--- a/Source/wtf/VectorTest.cpp
+++ b/Source/wtf/VectorTest.cpp
@@ -140,8 +140,8 @@ TEST(WTF_Vector, OwnPtr)
OwnPtr<DestructCounter>& counter0 = vector.first();
ASSERT_EQ(0, counter0->get());
- OwnPtr<DestructCounter>& counter1 = vector.last();
- ASSERT_EQ(1, counter1->get());
+ int counter1 = vector.last()->get();
+ ASSERT_EQ(1, counter1);
ASSERT_EQ(0, destructNumber);
size_t index = 0;
@@ -169,7 +169,7 @@ TEST(WTF_Vector, OwnPtr)
OwnPtr<DestructCounter> ownCounter1 = vector[0].release();
vector.remove(0);
- ASSERT_EQ(counter1.get(), ownCounter1.get());
+ ASSERT_EQ(counter1, ownCounter1->get());
ASSERT_EQ(0u, vector.size());
ASSERT_EQ(1, destructNumber);
« no previous file with comments | « Source/wtf/Vector.h ('k') | Source/wtf/wtf.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698