Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2284003002: Revert of IME for Mus: Make InputMethodMus use the IME Mojo API. (Closed)

Created:
4 years, 3 months ago by Elliot Glaysher
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, sadrul, sky, Hadi
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of IME for Mus: Make InputMethodMus use the IME Mojo API. (patchset #16 id:300001 of https://codereview.chromium.org/2230393002/ ) Reason for revert: All text input appears to be broken in chrome on mash, and I bisected to this patch. Reverting locally appears to fix this. Original issue's description: > IME for Mus: Make InputMethodMus use the IME Mojo API. > > This CL: > * Uses Mus' IMEServer to do the IME logic in InputMethodMus. > * Adds unittests to test InputMethodMus. > * Starts test_ime_driver on mus+ash session startup. > * Modifies test_ime_driver to not-handle non character events. > > BUG=548407 > > Committed: https://crrev.com/aa4f90ab72b60fd90e048b1e18193c30f0462d77 > Cr-Commit-Position: refs/heads/master@{#414748} TBR=sadrul@chromium.org,sky@chromium.org,tsepez@chromium.org,moshayedi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=548407 Committed: https://crrev.com/27e69a4464e4ea2a3a499a34960d9f108f9ea464 Cr-Commit-Position: refs/heads/master@{#414803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -376 lines) Patch
M services/ui/ime/ime_server_impl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M services/ui/ime/ime_server_impl.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M services/ui/ime/ime_unittest.cc View 3 chunks +10 lines, -36 lines 0 comments Download
M services/ui/ime/test_ime_driver/main.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/ime/test_ime_driver/test_ime_driver.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M services/ui/public/interfaces/ime.mojom View 1 chunk +0 lines, -9 lines 0 comments Download
M services/ui/service.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/mus/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
M ui/views/mus/input_method_mus.h View 3 chunks +8 lines, -22 lines 0 comments Download
M ui/views/mus/input_method_mus.cc View 3 chunks +29 lines, -63 lines 0 comments Download
D ui/views/mus/input_method_mus_unittest.cc View 1 chunk +0 lines, -99 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 2 chunks +0 lines, -8 lines 0 comments Download
D ui/views/mus/text_input_client_impl.h View 1 chunk +0 lines, -43 lines 0 comments Download
D ui/views/mus/text_input_client_impl.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.h View 4 chunks +2 lines, -5 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Elliot Glaysher
Created Revert of IME for Mus: Make InputMethodMus use the IME Mojo API.
4 years, 3 months ago (2016-08-26 20:49:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284003002/1
4 years, 3 months ago (2016-08-26 20:50:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 20:52:16 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 20:55:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27e69a4464e4ea2a3a499a34960d9f108f9ea464
Cr-Commit-Position: refs/heads/master@{#414803}

Powered by Google App Engine
This is Rietveld 408576698