Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/lithium.cc

Issue 22840002: Remove check for empty handle for CodeGenerator::MakeCodeEpilogue. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/full-codegen.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 443 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 454
455 MarkEmptyBlocks(); 455 MarkEmptyBlocks();
456 456
457 if (generator.GenerateCode()) { 457 if (generator.GenerateCode()) {
458 CodeGenerator::MakeCodePrologue(info(), "optimized"); 458 CodeGenerator::MakeCodePrologue(info(), "optimized");
459 Code::Flags flags = info()->flags(); 459 Code::Flags flags = info()->flags();
460 Handle<Code> code = 460 Handle<Code> code =
461 CodeGenerator::MakeCodeEpilogue(&assembler, flags, info()); 461 CodeGenerator::MakeCodeEpilogue(&assembler, flags, info());
462 generator.FinishCode(code); 462 generator.FinishCode(code);
463 code->set_is_crankshafted(true); 463 code->set_is_crankshafted(true);
464 if (!code.is_null()) { 464 void* jit_handler_data =
465 void* jit_handler_data = 465 assembler.positions_recorder()->DetachJITHandlerData();
466 assembler.positions_recorder()->DetachJITHandlerData(); 466 LOG_CODE_EVENT(info()->isolate(),
467 LOG_CODE_EVENT(info()->isolate(), 467 CodeEndLinePosInfoRecordEvent(*code, jit_handler_data));
468 CodeEndLinePosInfoRecordEvent(*code, jit_handler_data));
469 }
470 468
471 CodeGenerator::PrintCode(code, info()); 469 CodeGenerator::PrintCode(code, info());
472 return code; 470 return code;
473 } 471 }
474 return Handle<Code>::null(); 472 return Handle<Code>::null();
475 } 473 }
476 474
477 475
478 void LChunk::set_allocated_double_registers(BitVector* allocated_registers) { 476 void LChunk::set_allocated_double_registers(BitVector* allocated_registers) {
479 allocated_double_registers_ = allocated_registers; 477 allocated_double_registers_ = allocated_registers;
(...skipping 13 matching lines...) Expand all
493 491
494 492
495 LPhase::~LPhase() { 493 LPhase::~LPhase() {
496 if (ShouldProduceTraceOutput()) { 494 if (ShouldProduceTraceOutput()) {
497 isolate()->GetHTracer()->TraceLithium(name(), chunk_); 495 isolate()->GetHTracer()->TraceLithium(name(), chunk_);
498 } 496 }
499 } 497 }
500 498
501 499
502 } } // namespace v8::internal 500 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/full-codegen.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698