Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: src/codegen.cc

Issue 22840002: Remove check for empty handle for CodeGenerator::MakeCodeEpilogue. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/full-codegen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 107
108 // Allocate and install the code. 108 // Allocate and install the code.
109 CodeDesc desc; 109 CodeDesc desc;
110 bool is_crankshafted = 110 bool is_crankshafted =
111 Code::ExtractKindFromFlags(flags) == Code::OPTIMIZED_FUNCTION || 111 Code::ExtractKindFromFlags(flags) == Code::OPTIMIZED_FUNCTION ||
112 info->IsStub(); 112 info->IsStub();
113 masm->GetCode(&desc); 113 masm->GetCode(&desc);
114 Handle<Code> code = 114 Handle<Code> code =
115 isolate->factory()->NewCode(desc, flags, masm->CodeObject(), 115 isolate->factory()->NewCode(desc, flags, masm->CodeObject(),
116 false, is_crankshafted); 116 false, is_crankshafted);
117 if (!code.is_null()) { 117 isolate->counters()->total_compiled_code_size()->Increment(
118 isolate->counters()->total_compiled_code_size()->Increment( 118 code->instruction_size());
119 code->instruction_size()); 119 code->set_prologue_offset(info->prologue_offset());
120 code->set_prologue_offset(info->prologue_offset());
121 }
122 return code; 120 return code;
123 } 121 }
124 122
125 123
126 void CodeGenerator::PrintCode(Handle<Code> code, CompilationInfo* info) { 124 void CodeGenerator::PrintCode(Handle<Code> code, CompilationInfo* info) {
127 #ifdef ENABLE_DISASSEMBLER 125 #ifdef ENABLE_DISASSEMBLER
128 AllowDeferredHandleDereference allow_deference_for_print_code; 126 AllowDeferredHandleDereference allow_deference_for_print_code;
129 bool print_code = Isolate::Current()->bootstrapper()->IsActive() 127 bool print_code = Isolate::Current()->bootstrapper()->IsActive()
130 ? FLAG_print_builtin_code 128 ? FLAG_print_builtin_code
131 : (FLAG_print_code || 129 : (FLAG_print_code ||
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 ASSERT(result_size_ == 1 || result_size_ == 2); 224 ASSERT(result_size_ == 1 || result_size_ == 2);
227 #ifdef _WIN64 225 #ifdef _WIN64
228 return result | ((result_size_ == 1) ? 0 : 2); 226 return result | ((result_size_ == 1) ? 0 : 2);
229 #else 227 #else
230 return result; 228 return result;
231 #endif 229 #endif
232 } 230 }
233 231
234 232
235 } } // namespace v8::internal 233 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/full-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698