Batch all circular rrects together

Batch all circular rrects together

When possible, this change will place all circular rrect
types in the same batch. If the batch is all fills, we
use the fill shader, otherwise we use the stroke shader.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2283973002

Committed: https://skia.googlesource.com/skia/+/84839f6fb3d0de9088be3d53e81df195331ed1c9

[jvanverth1, 2016-08-26 20:31:36]

Description was changed from

==========
Batch all circular rrects together
==========

to

==========
Batch all circular rrects together
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2283973002
==========

[jvanverth1, 2016-08-29 15:13:01]

Description was changed from

==========
Batch all circular rrects together
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2283973002
==========

to

==========
Batch all circular rrects together

When possible, this change will place all circular rrect
types in the same batch. If the batch is all fills, we
use the fill shader, otherwise we use the stroke shader.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2283973002
==========

[jvanverth1, 2016-08-29 15:15:34]

jvanverth@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[robertphillips, 2016-08-29 15:43:21]

lgtm

https://codereview.chromium.org/2283973002/diff/40001/src/gpu/GrOvalRenderer.cpp
File src/gpu/GrOvalRenderer.cpp (right):

https://codereview.chromium.org/2283973002/diff/40001/src/gpu/GrOvalRenderer....
src/gpu/GrOvalRenderer.cpp:1569: const Geometry& args = fGeoData[i];
It seems a bit odd that we don't compute this as we accumulate the batch

[bsalomon, 2016-08-29 15:49:43]

https://codereview.chromium.org/2283973002/diff/40001/src/gpu/GrOvalRenderer.cpp
File src/gpu/GrOvalRenderer.cpp (right):

https://codereview.chromium.org/2283973002/diff/40001/src/gpu/GrOvalRenderer....
src/gpu/GrOvalRenderer.cpp:1586: // For fills, specifying 1/outerRadius
guarantees an alpha of 1.0 at the inner radius.
-1/outerRadius?

[jvanverth1, 2016-08-29 16:40:42]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2016-08-29 16:40:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2283973002/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2016-08-29 16:40:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jvanverth1, 2016-08-29 16:41:08]

https://codereview.chromium.org/2283973002/diff/40001/src/gpu/GrOvalRenderer.cpp
File src/gpu/GrOvalRenderer.cpp (right):

https://codereview.chromium.org/2283973002/diff/40001/src/gpu/GrOvalRenderer....
src/gpu/GrOvalRenderer.cpp:1569: const Geometry& args = fGeoData[i];
On 2016/08/29 15:43:21, robertphillips wrote:
> It seems a bit odd that we don't compute this as we accumulate the batch 

Done.

https://codereview.chromium.org/2283973002/diff/40001/src/gpu/GrOvalRenderer....
src/gpu/GrOvalRenderer.cpp:1586: // For fills, specifying 1/outerRadius
guarantees an alpha of 1.0 at the inner radius.
On 2016/08/29 15:49:43, bsalomon wrote:
> -1/outerRadius?

Done.

[commit-bot: I haz the power, 2016-08-29 17:16:43]

Description was changed from

==========
Batch all circular rrects together

When possible, this change will place all circular rrect
types in the same batch. If the batch is all fills, we
use the fill shader, otherwise we use the stroke shader.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2283973002
==========

to

==========
Batch all circular rrects together

When possible, this change will place all circular rrect
types in the same batch. If the batch is all fills, we
use the fill shader, otherwise we use the stroke shader.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2283973002

Committed:
https://skia.googlesource.com/skia/+/84839f6fb3d0de9088be3d53e81df195331ed1c9
==========

[commit-bot: I haz the power, 2016-08-29 17:16:43]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/84839f6fb3d0de9088be3d53e81df195331ed1c9