Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2283963002: Add ability to submit a form using javascript. (Closed)

Created:
4 years, 3 months ago by edchin
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ability to submit a form using javascript. BUG=none Committed: https://crrev.com/2bff664c86758d878d73eeee589184f72ed4a842 Cr-Commit-Position: refs/heads/master@{#414854}

Patch Set 1 #

Patch Set 2 : more descriptive naming #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M ios/web/public/test/web_view_interaction_test_util.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/test/web_view_interaction_test_util.mm View 1 3 chunks +14 lines, -1 line 2 comments Download

Messages

Total messages: 10 (4 generated)
edchin
baxley@chromium.org: Please review changes in eugenebut@chromium.org: Please review changes in
4 years, 3 months ago (2016-08-26 20:16:48 UTC) #3
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2283963002/diff/20001/ios/web/public/test/web_view_interaction_test_util.mm File ios/web/public/test/web_view_interaction_test_util.mm (right): https://codereview.chromium.org/2283963002/diff/20001/ios/web/public/test/web_view_interaction_test_util.mm#newcode21 ios/web/public/test/web_view_interaction_test_util.mm:21: ELEMENT_ACTION_SUBMIT Optional NIT: Maybe add comma after last ...
4 years, 3 months ago (2016-08-26 21:48:05 UTC) #4
edchin
https://codereview.chromium.org/2283963002/diff/20001/ios/web/public/test/web_view_interaction_test_util.mm File ios/web/public/test/web_view_interaction_test_util.mm (right): https://codereview.chromium.org/2283963002/diff/20001/ios/web/public/test/web_view_interaction_test_util.mm#newcode21 ios/web/public/test/web_view_interaction_test_util.mm:21: ELEMENT_ACTION_SUBMIT On 2016/08/26 21:48:05, Eugene But wrote: > Optional ...
4 years, 3 months ago (2016-08-26 22:26:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283963002/20001
4 years, 3 months ago (2016-08-26 22:33:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 23:19:26 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 23:21:25 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2bff664c86758d878d73eeee589184f72ed4a842
Cr-Commit-Position: refs/heads/master@{#414854}

Powered by Google App Engine
This is Rietveld 408576698