Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2283933002: [MD settings] layout sub-headers in display settings (Closed)

Created:
4 years, 3 months ago by dschuyler
Modified:
4 years, 3 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] layout sub-headers in display settings This CL is a follow-up to CL 2273083002 where the <h2> sub-labels were updated to the current mocks. The displays sub-page (chromeos only) also needed to be updated. BUG=638461 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7c959e62fb8e897367694fcc9743a3bbc0656917 Cr-Commit-Position: refs/heads/master@{#414855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M chrome/browser/resources/settings/device_page/display.html View 2 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dschuyler
4 years, 3 months ago (2016-08-26 19:17:42 UTC) #4
hcarmona
lgtm
4 years, 3 months ago (2016-08-26 21:28:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283933002/1
4 years, 3 months ago (2016-08-26 23:18:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 23:22:52 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 23:24:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c959e62fb8e897367694fcc9743a3bbc0656917
Cr-Commit-Position: refs/heads/master@{#414855}

Powered by Google App Engine
This is Rietveld 408576698