components/bookmarks.gypi - Issue 228393004: Create bookmarks component with names of bookmark preferences

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/bookmarks.gypi

Issue 228393004: Create bookmarks component with names of bookmark preferences (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add empty line at beginning and end of namespace Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 {

	6 'targets': [

	7 {

	8 'target_name': 'bookmarks',
	blundell 2014/04/09 09:13:00 bookmarks will be a layered component, right? If s bookmarks will be a layered component, right? If so, its internal structure should mirror that of e.g. autofill, so this target should be bookmarks_core_common. sdefresne 2014/04/09 13:16:07 Done. Show quoted text On 2014/04/09 09:13:00, blundell wrote: > bookmarks will be a layered component, right? If so, its internal structure > should mirror that of e.g. autofill, so this target should be > bookmarks_core_common. Done.
	9 'type': 'static_library',

	10 'include_dirs': [

	11 '..',

	12 ],

	13 'dependencies': [

	14 '../base/base.gyp:base',

	15 ],

	16 'sources': [

	17 'bookmarks/bookmark_pref_names.cc',

	18 'bookmarks/bookmark_pref_names.h',

	19 ],

	20 },

	21 ],

	22 }

OLD	NEW

« chrome/browser/android/bookmarks/bookmarks_bridge.cc ('K') | « chrome/common/pref_names.cc ('k') | components/bookmarks/DEPS » ('j') | no next file with comments »