components/bookmarks/bookmark_pref_names.h - Issue 228393004: Create bookmarks component with names of bookmark preferences

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/bookmarks/bookmark_pref_names.h

Issue 228393004: Create bookmarks component with names of bookmark preferences (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Re-upload with --no-find-copies Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
	tfarina 2014/04/08 16:30:34 optional-super-tiny-nit: some files use (c), other optional-super-tiny-nit: some files use (c), others don't, but as far as I know the right is without. sdefresne 2014/04/08 22:04:43 Done. Show quoted text On 2014/04/08 16:30:34, tfarina wrote: > optional-super-tiny-nit: some files use (c), others don't, but as far as I know > the right is without. Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Constants for the names of various bookmarks preferences.

	6

	7 #ifndef COMPONENTS_BOOKMARKS_BOOKMARK_PREF_NAMES_H_

	8 #define COMPONENTS_BOOKMARKS_BOOKMARK_PREF_NAMES_H_

	9

	10 namespace prefs {

	11 extern const char kBookmarkEditorExpandedNodes[];
	tfarina 2014/04/08 16:30:34 nit-nit: please, keep one blank line after namespa nit-nit: please, keep one blank line after namespace prefs. same below. sdefresne 2014/04/08 22:04:43 Done. Show quoted text On 2014/04/08 16:30:34, tfarina wrote: > nit-nit: please, keep one blank line after namespace prefs. same below. Done.
	12 extern const char kBookmarkPromptEnabled[];

	13 extern const char kBookmarkPromptImpressionCount[];

	14 extern const char kShowBookmarkBar[];

	15 extern const char kEditBookmarksEnabled[];

	16 extern const char kShowAppsShortcutInBookmarkBar[];

	17 } // namespace prefs

	18

	19 #endif // COMPONENTS_BOOKMARKS_BOOKMARK_PREF_NAMES_H_

OLD	NEW

« no previous file with comments | « components/bookmarks/OWNERS ('k') | components/bookmarks/bookmark_pref_names.cc » ('j') | components/components_tests.gyp » ('J')