Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2283923002: build_gyp: Remove deprecated flag, which is enabled by default. (Closed)

Created:
4 years, 3 months ago by vmpstr
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, Nico
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

build_gyp: Remove deprecated flag, which is enabled by default. This patch removes check-implicit-copy-ctors flag to the clang plugins. This flag is enabled by default and will be removed soon. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/35396df876cbf12c18a6de90e075b57adf74a1a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build_gyp/standalone.gypi View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
vmpstr
Please take a look.
4 years, 3 months ago (2016-08-26 18:44:41 UTC) #1
Lei Zhang
Clang things -> thakis
4 years, 3 months ago (2016-08-26 20:21:47 UTC) #3
Nico
lgtm
4 years, 3 months ago (2016-08-26 20:24:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283923002/1
4 years, 3 months ago (2016-08-26 20:36:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/35396df876cbf12c18a6de90e075b57adf74a1a7
4 years, 3 months ago (2016-08-26 20:52:47 UTC) #8
Lei Zhang
Oh, I didn't have enough coffee when I first looked. Should have told you all ...
4 years, 3 months ago (2016-08-26 21:38:50 UTC) #9
vmpstr
4 years, 3 months ago (2016-08-26 21:59:40 UTC) #10
Message was sent while issue was closed.
On 2016/08/26 21:38:50, Lei Zhang wrote:
> Oh, I didn't have enough coffee when I first looked. Should have told you all
> the gyp things are going bye-bye: https://codereview.chromium.org/2286653002/

Ah, no worries as long the flag is gone one way or another :)

Powered by Google App Engine
This is Rietveld 408576698