Expat target exports includes instead of FreeType.

Expat target exports includes instead of FreeType.

Currently when building for Android framework the freetype target
exports the expat include directory, but the freetype target neither
uses nor logically provides this information. Instead, the expat target
itself should do this.

Committed: https://skia.googlesource.com/skia/+/7147ee1b80ca739985e700e7c665f26653b84a76

[bungeman-skia, 2016-08-26 18:47:42]

Description was changed from

==========
Expat target exports includes instead of FreeType.

Currently when building for Android framework the freetype target
exports the expat include directory, but the freetype target neither
uses nor logically provide this information. Instead, the expat target
itself should do this.
==========

to

==========
Expat target exports includes instead of FreeType.

Currently when building for Android framework the freetype target
exports the expat include directory, but the freetype target neither
uses nor logically provide this information. Instead, the expat target
itself should do this.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2283903003
==========

[bungeman-skia, 2016-08-26 18:48:11]

Description was changed from

==========
Expat target exports includes instead of FreeType.

Currently when building for Android framework the freetype target
exports the expat include directory, but the freetype target neither
uses nor logically provide this information. Instead, the expat target
itself should do this.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2283903003
==========

to

==========
Expat target exports includes instead of FreeType.

Currently when building for Android framework the freetype target
exports the expat include directory, but the freetype target neither
uses nor logically provide this information. Instead, the expat target
itself should do this.
==========

[bungeman-skia, 2016-08-26 18:49:29]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 18:49:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-skia, 2016-08-26 18:51:31]

bungeman@google.com changed reviewers:
+ djsollen@google.com

[bungeman-skia, 2016-08-26 18:51:31]

While taking a peek at dependencies in general, I notices that the FreeType
target was exporting the expat includes, which seemed an odd thing to do. It
looks like this was a hack since, well, a looong time ago, and probably
shouldn't be done this way now. Unfortunately, I'm not sure off the top of my
head to pre-flight this sort of change to ensure it doesn't actually change the
generated Android build files. It shouldn't, but there's enough interactions
here it's difficult to be sure by inspection.

[bungeman-skia, 2016-08-26 18:51:55]

Description was changed from

==========
Expat target exports includes instead of FreeType.

Currently when building for Android framework the freetype target
exports the expat include directory, but the freetype target neither
uses nor logically provide this information. Instead, the expat target
itself should do this.
==========

to

==========
Expat target exports includes instead of FreeType.

Currently when building for Android framework the freetype target
exports the expat include directory, but the freetype target neither
uses nor logically provides this information. Instead, the expat target
itself should do this.
==========

[bungeman-skia, 2016-08-26 19:03:02]

On 2016/08/26 18:51:31, bungeman-skia wrote:
> While taking a peek at dependencies in general, I notices that the FreeType
> target was exporting the expat includes, which seemed an odd thing to do. It
> looks like this was a hack since, well, a looong time ago, and probably
> shouldn't be done this way now. Unfortunately, I'm not sure off the top of my
> head to pre-flight this sort of change to ensure it doesn't actually change
the
> generated Android build files. It shouldn't, but there's enough interactions
> here it's difficult to be sure by inspection.

Actually, I just ran

platform_tools/android/bin/gyp_to_android.py --gyp_source_dir
~/src/skia/third_party/externals/gyp
diff Android.mk ~/src/android/external/skia/Android.mk

and it seems to be the same, so I guess this works.

[djsollen, 2016-08-26 19:13:02]

lgtm

[bungeman-skia, 2016-08-26 19:13:54]

The CQ bit was unchecked by bungeman@google.com

[bungeman-skia, 2016-08-26 19:13:58]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2016-08-26 19:14:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 19:15:56]

Description was changed from

==========
Expat target exports includes instead of FreeType.

Currently when building for Android framework the freetype target
exports the expat include directory, but the freetype target neither
uses nor logically provides this information. Instead, the expat target
itself should do this.
==========

to

==========
Expat target exports includes instead of FreeType.

Currently when building for Android framework the freetype target
exports the expat include directory, but the freetype target neither
uses nor logically provides this information. Instead, the expat target
itself should do this.

Committed:
https://skia.googlesource.com/skia/+/7147ee1b80ca739985e700e7c665f26653b84a76
==========

[commit-bot: I haz the power, 2016-08-26 19:15:56]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7147ee1b80ca739985e700e7c665f26653b84a76