Skeleton of DM

dm/DMCpuTask.cpp

+#include "DMCpuTask.h"
+#include "DMReplayTask.h"
+#include "DMUtil.h"
+#include "SkCommandLineFlags.h"
+
+DEFINE_bool(replay, false, "If true, run replay tests for each CpuTask.");
+// TODO(mtklein): add the other various options
+
+namespace DM {
+
+CpuTask::CpuTask(const char* name,
+                 Reporter* reporter,
+                 TaskRunner* taskRunner,
+                 const skiagm::ExpectationsSource& expectations,
+                 skiagm::GMRegistry::Factory gmFactory,
+                 SkBitmap::Config config)
+    : Task(reporter, taskRunner)
+    , fGMFactory(gmFactory)
+    , fGM(fGMFactory(NULL))
+    , fName(underJoin(fGM->shortName(), name))
+    , fExpectations(expectations.get(png(fName).c_str()))
+    , fConfig(config)
+    {}
+
+void CpuTask::draw() {
+    SkBitmap bitmap;
+    bitmap.setConfig(fConfig, fGM->width(), fGM->height());
+    bitmap.allocPixels();
+    bitmap.eraseColor(0x00000000);
+    SkCanvas canvas(bitmap);
+
+    canvas.concat(fGM->getInitialTransform());
+    fGM->draw(&canvas);
+    canvas.flush();
+
+    const skiagm::GmResultDigest digest(bitmap);
+    if (!meetsExpectations(fExpectations, digest)) {
+        this->fail();

[epoger, 2013/10/11 21:13:13]

So, are different types of failures (no_comparison, failed, failure_ignored)
still tallied separately?

[mtklein, 2013/10/15 18:30:53]

Ah, good catch.  I intended to count failures but none of the rest, but I think
the no_comparisons were probably getting lumped in there with the failures. 
I've updated DMUtil.cpp's meetsExpectations to only fail on a non-ignored
non-degenerate mismatch.

+    }
+
+    if (FLAGS_replay) {
+        this->spawnChild(SkNEW_ARGS(ReplayTask,
+                                   ("replay", *this, fGMFactory(NULL), digest, fConfig)));
+    }
+}
+
+bool CpuTask::shouldSkip() const {
+    if (SkBitmap::kRGB_565_Config == fConfig && (fGM->getFlags() & skiagm::GM::kSkip565_Flag)) {

[epoger, 2013/10/11 21:13:13]

Why is this the only config we check whether to skip?  Shouldn't it be a more
complete list of possible configs?

[mtklein, 2013/10/15 18:30:53]

Hmm.  Looks like I was being a little cute here.  I've updated it to maybe be
clearer?

I think this is correct.  The only things we need to check are that we don't
want to run 565 when we say to skip it, and that we don't run GPU-only tasks. 
The other flags don't affect this task as far as I can tell.

[epoger, 2013/10/15 18:52:37]

Easier to follow now, thanks.

+        return true;
+    }
+    return fGM->getFlags() & skiagm::GM::kGPUOnly_Flag;
+}
+
+}  // namespace DM