native_client_sdk/src/build_tools/build_projects.py - Issue 22839005: disable pnacl by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/build_tools/build_projects.py

Issue 22839005: disable pnacl by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove some unintended revert changes Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/build_tools/build_projects.py

diff --git a/native_client_sdk/src/build_tools/build_projects.py b/native_client_sdk/src/build_tools/build_projects.py

index 20f3f7ca3aae2fbb44e66086a54fefd681da966a..34c717f6f09289bab537ca6cd2ab980ed66d6a79 100755

--- a/native_client_sdk/src/build_tools/build_projects.py

+++ b/native_client_sdk/src/build_tools/build_projects.py

@@ -104,6 +104,9 @@ def UpdateProjects(pepperdir, project_tree, toolchains,

buildbot_common.RemoveDir(dirpath)

buildbot_common.MakeDir(dirpath)

+ if toolchain == 'pnacl':

binji 2013/08/12 17:59:35 this seems to be in the wrong file. It should be i

sehr 2013/08/12 18:43:14 Done.

+ args.extend(['--browser_flag', '--enable-pnacl'])

landing_page = None

for branch, projects in project_tree.iteritems():

dirpath = os.path.join(pepperdir, branch)