Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1408)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22839005: disable pnacl by default (Closed)

Created:
7 years, 4 months ago by sehr
Modified:
7 years, 4 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com, binji, Sam Clegg
Visibility:
Public.

Description

disable pnacl by default. PNaCl was disabled by default for M30 because of two security requirements that could not be met in time for the beta channel entry and to because the stable ABI effort took longer than expected, resulting in insufficient developer dogfood time. BUG=none R=bbudge@chromium.org, bradnelson@chromium.org, bradnelson@google.com, darin@chromium.org, jhawkins@chromium.org, jvoung@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217106

Patch Set 1 #

Patch Set 2 : Remove some unintended revert changes #

Total comments: 6

Patch Set 3 : Fixes for binji's review #

Total comments: 2

Patch Set 4 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -104 lines) Patch
M build/ios/grit_whitelist.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/nacl_ui.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/renderer/pepper/ppb_nacl_private_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/nacl/pnacl_mime_type/pnacl_mime_type.html View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/test/nacl/nacl_browsertest.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M chrome/test/nacl/nacl_browsertest_uma.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/nacl/nacl_browsertest_util.h View 3 chunks +3 lines, -16 lines 0 comments Download
M chrome/test/nacl/nacl_browsertest_util.cc View 5 chunks +12 lines, -45 lines 0 comments Download
M chrome/test/ppapi/ppapi_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin_error.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/service_runtime.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
sehr
This CL needs to land before the M30 branch. PTAL.
7 years, 4 months ago (2013-08-12 17:56:19 UTC) #1
binji
https://codereview.chromium.org/22839005/diff/3001/native_client_sdk/src/build_tools/build_projects.py File native_client_sdk/src/build_tools/build_projects.py (right): https://codereview.chromium.org/22839005/diff/3001/native_client_sdk/src/build_tools/build_projects.py#newcode107 native_client_sdk/src/build_tools/build_projects.py:107: if toolchain == 'pnacl': this seems to be in ...
7 years, 4 months ago (2013-08-12 17:59:35 UTC) #2
sehr
Thanks. I appear to have applied the right change to the wrong file... PTAL. https://codereview.chromium.org/22839005/diff/3001/native_client_sdk/src/build_tools/build_projects.py ...
7 years, 4 months ago (2013-08-12 18:43:14 UTC) #3
sehr
Adding Bill, as David is out.
7 years, 4 months ago (2013-08-12 19:55:53 UTC) #4
bradn
lgtm
7 years, 4 months ago (2013-08-12 19:57:15 UTC) #5
bradnelson
lgtm
7 years, 4 months ago (2013-08-12 19:57:30 UTC) #6
jvoung (off chromium)
https://codereview.chromium.org/22839005/diff/11001/ppapi/native_client/chrome_main.scons File ppapi/native_client/chrome_main.scons (right): https://codereview.chromium.org/22839005/diff/11001/ppapi/native_client/chrome_main.scons#newcode469 ppapi/native_client/chrome_main.scons:469: browser_flags.append('--enable-pnacl') We don't need this anymore, since we ripped ...
7 years, 4 months ago (2013-08-12 20:04:40 UTC) #7
bbudge
LGTM with a comment. https://codereview.chromium.org/22839005/diff/3001/chrome/common/chrome_switches.h File chrome/common/chrome_switches.h (right): https://codereview.chromium.org/22839005/diff/3001/chrome/common/chrome_switches.h#newcode192 chrome/common/chrome_switches.h:192: extern const char kDisablePnaclInstall[]; Either ...
7 years, 4 months ago (2013-08-12 20:04:41 UTC) #8
jvoung (off chromium)
otherwise, LGTM
7 years, 4 months ago (2013-08-12 20:05:09 UTC) #9
James Hawkins
lgtm
7 years, 4 months ago (2013-08-12 20:08:57 UTC) #10
sehr
Thanks for the reviews. New version uploaded. https://codereview.chromium.org/22839005/diff/3001/chrome/common/chrome_switches.h File chrome/common/chrome_switches.h (right): https://codereview.chromium.org/22839005/diff/3001/chrome/common/chrome_switches.h#newcode192 chrome/common/chrome_switches.h:192: extern const ...
7 years, 4 months ago (2013-08-12 20:21:31 UTC) #11
darin (slow to review)
LGTM
7 years, 4 months ago (2013-08-12 20:22:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sehr@chromium.org/22839005/11002
7 years, 4 months ago (2013-08-12 20:28:40 UTC) #13
sehr
7 years, 4 months ago (2013-08-12 22:52:55 UTC) #14
Message was sent while issue was closed. 
Committed patchset #4 manually as r217106 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698