runtime/vm/intrinsifier_arm.cc - Issue 22839003: Polymorphic inlining for some recognized methods in the optimizing compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_arm.cc

Issue 22839003: Polymorphic inlining for some recognized methods in the optimizing compiler. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: fixed modulo performance regression Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intrinsifier_arm.cc

===================================================================

--- runtime/vm/intrinsifier_arm.cc (revision 26420)

+++ runtime/vm/intrinsifier_arm.cc (working copy)

@@ -712,10 +712,14 @@

// res = res + right;

// }

-bool Intrinsifier::Integer_modulo(Assembler* assembler) {

+bool Intrinsifier::Integer_moduloFromInteger(Assembler* assembler) {

// Check to see if we have integer division

Label fall_through, subtract;

- TestBothArgumentsSmis(assembler, &fall_through);

+ __ ldr(R1, Address(SP, + 0 * kWordSize));

+ __ ldr(R0, Address(SP, + 1 * kWordSize));

+ __ orr(TMP, R0, ShifterOperand(R1));

+ __ tst(TMP, ShifterOperand(kSmiTagMask));

+ __ b(&fall_through, NE);

// R1: Tagged left (dividend).

// R0: Tagged right (divisor).

// Check if modulo by zero -> exception thrown in main function.

« no previous file with comments | « runtime/vm/intrinsifier.h ('k') | runtime/vm/intrinsifier_ia32.cc » ('j') | no next file with comments »