Polymorphic inlining for some recognized methods in the optimizing compiler.

runtime/vm/intermediate_language.cc

Index: runtime/vm/intermediate_language.cc
===================================================================
--- runtime/vm/intermediate_language.cc	(revision 25997)
+++ runtime/vm/intermediate_language.cc	(working copy)
@@ -1776,6 +1776,14 @@
 }
 
 
+bool PolymorphicInstanceCallInstr::HasRecognizedTarget() const {
+  return ic_data().HasOneTarget() &&
+      (MethodRecognizer::RecognizeKind(
+          Function::Handle(ic_data().GetTargetAt(0))) !=
+       MethodRecognizer::kUnknown);

[srdjan, 2013/08/12 21:49:47]

indent strange, I think it should be:
return ic_data().HasOneTarget() &&
    (MethodRecognizer::RecognizeKind(
        Function::Handle(ic_data().GetTargetAt(0))) !=
            MethodRecognizer::kUnknown);

[Kevin Millikin (Google), 2013/08/13 11:47:40]

I think it should be:

if (!ic_data().HasOneTarget()) return false;
const Function& target = Function::Handle(ic_data().GetTargetAt(0));
return
    (MethodRecognizer::RecognizeKind(target) != MethodRecognizer::kUnknown);

;)

[Florian Schneider, 2013/08/14 12:30:24]

Done.

+}
+
+
 LocationSummary* StaticCallInstr::MakeLocationSummary() const {
   return MakeCallSummary();
 }