Polymorphic inlining for some recognized methods in the optimizing compiler.

runtime/vm/intermediate_language.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/intermediate_language.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/bit_vector.h"
 #include "vm/dart_entry.h"
 #include "vm/flow_graph_allocator.h"
@@ skipping 1758 matching lines @@
     compiler->GenerateInstanceCall(deopt_id(),
                                    token_pos(),
                                    ArgumentCount(),
                                    argument_names(),
                                    locs(),
                                    call_ic_data);
   }
 }
 
 
+bool PolymorphicInstanceCallInstr::HasRecognizedTarget() const {
+  return ic_data().HasOneTarget() &&
+      (MethodRecognizer::RecognizeKind(
+          Function::Handle(ic_data().GetTargetAt(0))) !=
+       MethodRecognizer::kUnknown);

[srdjan, 2013/08/12 21:49:47]

indent strange, I think it should be:
return ic_data().HasOneTarget() &&
    (MethodRecognizer::RecognizeKind(
        Function::Handle(ic_data().GetTargetAt(0))) !=
            MethodRecognizer::kUnknown);

[Kevin Millikin (Google), 2013/08/13 11:47:40]

I think it should be:

if (!ic_data().HasOneTarget()) return false;
const Function& target = Function::Handle(ic_data().GetTargetAt(0));
return
    (MethodRecognizer::RecognizeKind(target) != MethodRecognizer::kUnknown);

;)

[Florian Schneider, 2013/08/14 12:30:24]

Done.

+}
+
+
 LocationSummary* StaticCallInstr::MakeLocationSummary() const {
   return MakeCallSummary();
 }
 
 
 void StaticCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   Label skip_call;
   if (!compiler->is_optimizing()) {
     // Some static calls can be optimized by the optimizing compiler (e.g. sqrt)
     // and therefore need a deoptimization descriptor.
@@ skipping 812 matching lines @@
     default:
       UNREACHABLE();
   }
   return kPowRuntimeEntry;
 }
 
 
 #undef __
 
 }  // namespace dart