Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2283893002: Move onclick handler in svg/animations/use-animate-width-and-height.html (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
Stephen Chennney
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move onclick handler in svg/animations/use-animate-width-and-height.html We can no longer listen after events on something that is an instance in a <use>. Move the executeTest() call to the <use> element instead. Since the mentioned file is almost a stub, the actual change is in svg/animations/script-tests/use-animate-width-and-height.js. BUG=641398 Committed: https://crrev.com/6a43874e66bd2f5511a09028013481d653cbf86f Cr-Commit-Position: refs/heads/master@{#414776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/svg/animations/script-tests/use-animate-width-and-height.js View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
fs
4 years, 3 months ago (2016-08-26 18:26:21 UTC) #5
Stephen Chennney
Thanks for fixing. LGTM.
4 years, 3 months ago (2016-08-26 18:43:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283893002/1
4 years, 3 months ago (2016-08-26 18:52:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 19:26:58 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 19:28:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a43874e66bd2f5511a09028013481d653cbf86f
Cr-Commit-Position: refs/heads/master@{#414776}

Powered by Google App Engine
This is Rietveld 408576698