Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: runtime/observatory/tests/observatory_ui/objectpool_view/element_test.dart

Issue 2283863003: Converted Observatory object-pool-view element (Closed)
Patch Set: Addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/observatory_ui/objectpool_view/element_test.dart
diff --git a/runtime/observatory/tests/observatory_ui/context_view/element_test.dart b/runtime/observatory/tests/observatory_ui/objectpool_view/element_test.dart
similarity index 69%
copy from runtime/observatory/tests/observatory_ui/context_view/element_test.dart
copy to runtime/observatory/tests/observatory_ui/objectpool_view/element_test.dart
index 428aefd179f11db2e5124cc5dc283cd72e4140e7..11f2ee946e0268a92f4d158ec50bdf8881149b4f 100644
--- a/runtime/observatory/tests/observatory_ui/context_view/element_test.dart
+++ b/runtime/observatory/tests/observatory_ui/objectpool_view/element_test.dart
@@ -4,13 +4,13 @@
import 'dart:html';
import 'package:unittest/unittest.dart';
-import 'package:observatory/src/elements/context_view.dart';
import 'package:observatory/src/elements/nav/refresh.dart';
import 'package:observatory/src/elements/object_common.dart';
+import 'package:observatory/src/elements/objectpool_view.dart';
import '../mocks.dart';
main() {
- ContextViewElement.tag.ensureRegistration();
+ ObjectPoolViewElement.tag.ensureRegistration();
final cTag = ObjectCommonElement.tag.name;
final rTag = NavRefreshElement.tag.name;
@@ -19,32 +19,32 @@ main() {
const isolate = const IsolateRefMock();
final events = new EventRepositoryMock();
final notifs = new NotificationRepositoryMock();
- final context = const ContextMock();
- final contexts = new ContextRepositoryMock();
+ final pool = const ObjectPoolMock();
+ final pools = new ObjectPoolRepositoryMock();
final reachableSizes = new ReachableSizeRepositoryMock();
final retainedSizes = new RetainedSizeRepositoryMock();
final inbounds = new InboundReferencesRepositoryMock();
final paths = new RetainingPathRepositoryMock();
final instances = new InstanceRepositoryMock();
test('instantiation', () {
- final e = new ContextViewElement(vm, isolate, context, events, notifs,
- contexts, retainedSizes, reachableSizes,
- inbounds, paths, instances);
+ final e = new ObjectPoolViewElement(vm, isolate, pool, events, notifs,
+ pools, retainedSizes, reachableSizes,
+ inbounds, paths, instances);
expect(e, isNotNull, reason: 'element correctly created');
expect(e.isolate, equals(isolate));
- expect(e.context, equals(context));
+ expect(e.pool, equals(pool));
});
test('elements created after attachment', () async {
- final contexts = new ContextRepositoryMock(
+ final pools = new ObjectPoolRepositoryMock(
getter: expectAsync((i, id) async {
expect(i, equals(isolate));
- expect(id, equals(context.id));
- return context;
+ expect(id, equals(pool.id));
+ return pool;
}, count: 1)
);
- final e = new ContextViewElement(vm, isolate, context, events, notifs,
- contexts, retainedSizes, reachableSizes,
- inbounds, paths, instances);
+ final e = new ObjectPoolViewElement(vm, isolate, pool, events, notifs,
+ pools, retainedSizes, reachableSizes,
+ inbounds, paths, instances);
document.body.append(e);
await e.onRendered.first;
expect(e.children.length, isNonZero, reason: 'has elements');

Powered by Google App Engine
This is Rietveld 408576698