Disable the MD Clear Browsing Data dialog checkboxes during clearing

Disable the MD Clear Browsing Data dialog checkboxes during clearing

When clearing is in progress, we disable the buttons. We should also
disable the checkboxes.

Leaving them enabled not only gives the false impression that the
datatype selection is modifiable during clearing, it can also have
an undesired effect: When the clearing finishes, we show the message
about other forms of history based on whether the history checkbox was
checked - and thus we shouldn't allow (un)checking in.

https://screenshot.googleplex.com/0VXxxLtXHZU.png

BUG=595580
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/216137680ffb4c021f75180c57e6dd6ca4d5c772
Cr-Commit-Position: refs/heads/master@{#414784}

[msramek, 2016-08-26 16:27:41]

Description was changed from

==========
Disable the MD Clear Browsing Data dialog checkboxes during clearing

When clearing is in progress, we disable the buttons. We should also
disable the checkboxes.

Leaving them enabled not only gives the false impression that the
datatype selection is modifiable during clearing, it can also have
an undesired effect: When the clearing finishes, we show the message
about other forms of history based on whether the history checkbox was
checked - and thus we shouldn't allow (un)checking in.

https://screenshot.googleplex.com/0VXxxLtXHZU.png

BUG=595580
==========

to

==========
Disable the MD Clear Browsing Data dialog checkboxes during clearing

When clearing is in progress, we disable the buttons. We should also
disable the checkboxes.

Leaving them enabled not only gives the false impression that the
datatype selection is modifiable during clearing, it can also have
an undesired effect: When the clearing finishes, we show the message
about other forms of history based on whether the history checkbox was
checked - and thus we shouldn't allow (un)checking in.

https://screenshot.googleplex.com/0VXxxLtXHZU.png

BUG=595580
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[msramek, 2016-08-26 16:28:07]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 16:28:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2016-08-26 16:31:13]

msramek@chromium.org changed reviewers:
+ dschuyler@chromium.org

[msramek, 2016-08-26 16:31:14]

Hi Dave,

Please have a look!

This copy-pasting is not very elegant, but I guess iterating over the checkboxes
using JS is not polymer-y... and replacing the div with some kind of checkbox
container class would be an overkill.

Thanks,
Martin

[dschuyler, 2016-08-26 17:45:16]

Thanks for considering those alternatives. I think this is the right choice
(adding the property to each checkbox).  LGTM

[commit-bot: I haz the power, 2016-08-26 19:14:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 19:14:05]

Dry run: This issue passed the CQ dry run.

[msramek, 2016-08-26 19:37:33]

Thanks!

[msramek, 2016-08-26 19:37:38]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2016-08-26 19:39:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 19:44:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-26 19:47:52]

Description was changed from

==========
Disable the MD Clear Browsing Data dialog checkboxes during clearing

When clearing is in progress, we disable the buttons. We should also
disable the checkboxes.

Leaving them enabled not only gives the false impression that the
datatype selection is modifiable during clearing, it can also have
an undesired effect: When the clearing finishes, we show the message
about other forms of history based on whether the history checkbox was
checked - and thus we shouldn't allow (un)checking in.

https://screenshot.googleplex.com/0VXxxLtXHZU.png

BUG=595580
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Disable the MD Clear Browsing Data dialog checkboxes during clearing

When clearing is in progress, we disable the buttons. We should also
disable the checkboxes.

Leaving them enabled not only gives the false impression that the
datatype selection is modifiable during clearing, it can also have
an undesired effect: When the clearing finishes, we show the message
about other forms of history based on whether the history checkbox was
checked - and thus we shouldn't allow (un)checking in.

https://screenshot.googleplex.com/0VXxxLtXHZU.png

BUG=595580
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/216137680ffb4c021f75180c57e6dd6ca4d5c772
Cr-Commit-Position: refs/heads/master@{#414784}
==========

[commit-bot: I haz the power, 2016-08-26 19:47:54]

Patchset 1 (id:??) landed as
https://crrev.com/216137680ffb4c021f75180c57e6dd6ca4d5c772
Cr-Commit-Position: refs/heads/master@{#414784}