Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2283843002: Hoist updateAnimation() calls from SVGSMILElement::progress (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
pdr.
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hoist updateAnimation() calls from SVGSMILElement::progress The updateAnimation() calls in SVGSMILElement::progress() corresponds to the timed element contributing to the animation "sandwich", so it's trivial to hoist it out into the caller. Well there, the |resultElement| logic can be replaced with a vector onto contributing timed elements are appended. When all contributing timed elements are collected the value is computed. BUG=641437 Committed: https://crrev.com/c4f7094a1f713541aab18286d664f8dae1826eba Cr-Commit-Position: refs/heads/master@{#414937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -29 lines) Patch
M third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp View 3 chunks +20 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp View 4 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
fs
The latest invention from the Crazy Clown's SMIL(e) Factory.
4 years, 3 months ago (2016-08-26 18:49:30 UTC) #7
pdr.
On 2016/08/26 at 18:49:30, fs wrote: > The latest invention from the Crazy Clown's SMIL(e) ...
4 years, 3 months ago (2016-08-26 22:04:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283843002/1
4 years, 3 months ago (2016-08-27 15:39:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-27 15:42:58 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-27 15:44:47 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4f7094a1f713541aab18286d664f8dae1826eba
Cr-Commit-Position: refs/heads/master@{#414937}

Powered by Google App Engine
This is Rietveld 408576698