Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2283833002: Delete unused function GenerateSpecificPEFileVersion(). (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete unused function GenerateSpecificPEFileVersion(). This function is no longer used. Also, it was too easy to misuse it by passing a target version with a different length than the original version. BUG=595809 Committed: https://crrev.com/98bae263014aad2d3ef0910edef31a8ee32a6c17 Cr-Commit-Position: refs/heads/master@{#414945}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -28 lines) Patch
M chrome/installer/test/alternate_version_generator.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/installer/test/alternate_version_generator.cc View 1 chunk +5 lines, -20 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
fdoray
PTAL
4 years, 3 months ago (2016-08-26 20:09:03 UTC) #2
grt (UTC plus 2)
lgtm
4 years, 3 months ago (2016-08-26 20:14:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283833002/1
4 years, 3 months ago (2016-08-27 21:54:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-27 22:37:11 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-27 22:39:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98bae263014aad2d3ef0910edef31a8ee32a6c17
Cr-Commit-Position: refs/heads/master@{#414945}

Powered by Google App Engine
This is Rietveld 408576698