Modernize SelectFileDialogImplKDE.

Modernize SelectFileDialogImplKDE.

Use base::Bind and content::BrowserThread::PostTaskAndReplyWithResults()
instead of custom function pointer based callbacks.

Committed: https://crrev.com/5caadda2a293952297486a4e2e55671e0e6d0202
Cr-Commit-Position: refs/heads/master@{#414792}

[Lei Zhang, 2016-08-26 18:18:12]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 18:19:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-08-26 18:21:23]

thestig@chromium.org changed reviewers:
+ thomasanderson@chromium.org

[Tom (Use chromium acct), 2016-08-26 18:46:23]

thomasanderson@google.com changed reviewers:
+ thomasanderson@google.com

[Tom (Use chromium acct), 2016-08-26 18:46:23]

lgtm

https://codereview.chromium.org/2283823003/diff/1/chrome/browser/ui/libgtk2ui...
File chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc (right):

https://codereview.chromium.org/2283823003/diff/1/chrome/browser/ui/libgtk2ui...
chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc:321:
base::GetAppOutputWithExitCode(command_line, &output, &exit_code);
Nit: Can we just do &results->output, &results->exit_code and skip the
temporaries?

[commit-bot: I haz the power, 2016-08-26 19:11:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 19:11:27]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-08-26 19:18:08]

https://codereview.chromium.org/2283823003/diff/1/chrome/browser/ui/libgtk2ui...
File chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc (right):

https://codereview.chromium.org/2283823003/diff/1/chrome/browser/ui/libgtk2ui...
chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc:321:
base::GetAppOutputWithExitCode(command_line, &output, &exit_code);
On 2016/08/26 18:46:23, Tom Anderson wrote:
> Nit: Can we just do &results->output, &results->exit_code and skip the
> temporaries?

Done.

[Lei Zhang, 2016-08-26 19:18:15]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-08-26 19:18:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
thomasanderson@google.com
Link to the patchset: https://codereview.chromium.org/2283823003/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2016-08-26 19:19:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 20:19:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-26 20:21:49]

Description was changed from

==========
Modernize SelectFileDialogImplKDE.

Use base::Bind and content::BrowserThread::PostTaskAndReplyWithResults()
instead of custom function pointer based callbacks.
==========

to

==========
Modernize SelectFileDialogImplKDE.

Use base::Bind and content::BrowserThread::PostTaskAndReplyWithResults()
instead of custom function pointer based callbacks.

Committed: https://crrev.com/5caadda2a293952297486a4e2e55671e0e6d0202
Cr-Commit-Position: refs/heads/master@{#414792}
==========

[commit-bot: I haz the power, 2016-08-26 20:21:50]

Patchset 2 (id:??) landed as
https://crrev.com/5caadda2a293952297486a4e2e55671e0e6d0202
Cr-Commit-Position: refs/heads/master@{#414792}