Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.js

Issue 2283803003: PDF: Add shortcut to toggle fit-to-{page,width}. (Closed)
Patch Set: Extend testZoomToolbarToggle Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/pdf/pdf.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.js
diff --git a/chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.js b/chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.js
index 060178fcc6fe214d82b0b5d3ffdf5957b50346e7..3ade73b7174a78855fed005c89f5afdb0375bc53 100644
--- a/chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.js
+++ b/chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.js
@@ -27,6 +27,7 @@
},
/**
+ * @private
* Change button tooltips to match any changes to localized strings.
*/
updateTooltips_: function() {
@@ -38,6 +39,9 @@
this.$['zoom-out-button'].tooltips = [this.strings.tooltipZoomOut];
},
+ /**
+ * Handle clicks of the fit-button.
+ */
fitToggle: function() {
if (this.$['fit-button'].activeIndex == FIT_TO_WIDTH)
this.fire('fit-to-width');
@@ -45,10 +49,30 @@
this.fire('fit-to-page');
},
+ /**
+ * Handle the keyboard shortcut equivalent of fit-button clicks.
+ */
+ fitToggleFromHotKey: function() {
+ this.fitToggle();
+
+ // Toggle the button state since there was no mouse click.
+ var button = this.$['fit-button'];
+ if (button.activeIndex == FIT_TO_WIDTH)
+ button.activeIndex = FIT_TO_PAGE;
+ else
+ button.activeIndex = FIT_TO_WIDTH;
+ },
+
+ /**
+ * Handle clicks of the zoom-in-button.
+ */
zoomIn: function() {
this.fire('zoom-in');
},
+ /**
+ * Handle clicks of the zoom-out-button.
+ */
zoomOut: function() {
this.fire('zoom-out');
},
« no previous file with comments | « no previous file | chrome/browser/resources/pdf/pdf.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698