Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2283803002: Add histogram to track overhead for scanning external css (Closed)

Created:
4 years, 3 months ago by Charlie Harrison
Modified:
4 years, 3 months ago
Reviewers:
Mark P, kouhei (in TOK)
CC:
chromium-reviews, tyoshino+watch_chromium.org, blink-reviews-style_chromium.org, tfarina, blink-reviews-html_chromium.org, Yoav Weiss, loading-reviews+parser_chromium.org, loading-reviews_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, asvitkine+watch_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add histogram to track overhead for scanning external css This patch adds a histogram to count the microseconds used to preload scan the first chunk of CSS for the @import scanning experiment. BUG=596676 Committed: https://crrev.com/dee540ca7dff49cf44ed84443e2d266e462e2c52 Cr-Commit-Position: refs/heads/master@{#414787}

Patch Set 1 #

Patch Set 2 : properly set upstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +7 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (8 generated)
Charlie Harrison
Kouhei, do you think the copy+scan of the first chunk of css could take over ...
4 years, 3 months ago (2016-08-26 13:54:15 UTC) #4
kouhei (in TOK)
lgtm
4 years, 3 months ago (2016-08-26 15:17:34 UTC) #5
Charlie Harrison
Thanks! +mpearson for histograms.xml review.
4 years, 3 months ago (2016-08-26 15:22:32 UTC) #7
Mark P
lgtm
4 years, 3 months ago (2016-08-26 18:04:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283803002/20001
4 years, 3 months ago (2016-08-26 19:47:03 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 19:52:10 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 19:54:19 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dee540ca7dff49cf44ed84443e2d266e462e2c52
Cr-Commit-Position: refs/heads/master@{#414787}

Powered by Google App Engine
This is Rietveld 408576698