third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp - Issue 2283783002: Move static methods out of CSSLengthInterpolationType to LengthInterpolationFunctions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp

Issue 2283783002: Move static methods out of CSSLengthInterpolationType to LengthInterpolationFunctions (Closed)

Patch Set: Fix compile Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp

index 8cad2e94899abe4e139102eecd0e93443ed63720..a24cd4249940f5dc8297ef9538fbd4e665a2e4f6 100644

--- a/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp

@@ -4,7 +4,7 @@

#include "core/animation/CSSClipInterpolationType.h"

-#include "core/animation/CSSLengthInterpolationType.h"

+#include "core/animation/LengthInterpolationFunctions.h"

#include "core/css/CSSQuadValue.h"

#include "core/css/resolver/StyleResolverState.h"

#include "wtf/PtrUtil.h"

@@ -150,7 +150,7 @@ static std::unique_ptr<InterpolableValue> convertClipComponent(const Length& len

{

if (length.isAuto())

return InterpolableList::create(0);

- return CSSLengthInterpolationType::maybeConvertLength(length, zoom).interpolableValue;

+ return LengthInterpolationFunctions::maybeConvertLength(length, zoom).interpolableValue;

}

static InterpolationValue createClipValue(const LengthBox& clip, double zoom)

@@ -200,7 +200,7 @@ static std::unique_ptr<InterpolableValue> convertClipComponent(const CSSPrimitiv

{

if (isCSSAuto(length))

return InterpolableList::create(0);

- return CSSLengthInterpolationType::maybeConvertCSSValue(length).interpolableValue;

+ return LengthInterpolationFunctions::maybeConvertCSSValue(length).interpolableValue;

}

InterpolationValue CSSClipInterpolationType::maybeConvertValue(const CSSValue& value, const StyleResolverState& state, ConversionCheckers&) const

@@ -255,7 +255,7 @@ void CSSClipInterpolationType::apply(const InterpolableValue& interpolableValue,

{

if (isAuto)

return Length(Auto);

- return CSSLengthInterpolationType::createLength(*list.get(index), nullptr, environment.state().cssToLengthConversionData(), ValueRangeAll);

+ return LengthInterpolationFunctions::createLength(*list.get(index), nullptr, environment.state().cssToLengthConversionData(), ValueRangeAll);

};

environment.state().style()->setClip(LengthBox(

convertIndex(autos.isTopAuto, ClipTop),