Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2283743002: Revert of Support server categories in NTPSnippetsService. (Closed)

Created:
4 years, 3 months ago by johnme
Modified:
4 years, 3 months ago
Reviewers:
Marc Treib, sfiera
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, Philipp Keck
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Support server categories in NTPSnippetsService. (patchset #3 id:40001 of https://codereview.chromium.org/2279863002/ ) Reason for revert: I'm afraid this failed again on https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/27385/steps/components_unittests%20on%20Mac-10.9 Original issue's description: > Support server categories in NTPSnippetsService. > > Reland of: > https://crrev.com/330958ddcdcd0084d724571eddaa66f9c364115f > > Not clear why tests failed; they passed for me and in the CQ. > Removed one synchronization bit that wasn't really part of the change. > > BUG=633613 > > Committed: https://crrev.com/880bb766ee4985a8dd36be10098c5196c41f7509 > Cr-Commit-Position: refs/heads/master@{#414681} TBR=treib@chromium.org,sfiera@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=633613 Committed: https://crrev.com/bc1a4e2725d8166b45bff9b8ce4edd6679ab0f1d Cr-Commit-Position: refs/heads/master@{#414686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -449 lines) Patch
M components/ntp_snippets/ntp_snippets_fetcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/ntp_snippets/ntp_snippets_service.h View 6 chunks +21 lines, -37 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.cc View 21 chunks +178 lines, -348 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service_unittest.cc View 20 chunks +47 lines, -63 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
johnme
Created Revert of Support server categories in NTPSnippetsService.
4 years, 3 months ago (2016-08-26 11:22:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283743002/1
4 years, 3 months ago (2016-08-26 11:23:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 11:24:13 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 11:25:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc1a4e2725d8166b45bff9b8ce4edd6679ab0f1d
Cr-Commit-Position: refs/heads/master@{#414686}

Powered by Google App Engine
This is Rietveld 408576698