Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 22837006: Have DataTransferItemList.add() methods return the added item (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, jeez, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, do-not-use
Visibility:
Public.

Description

Have DataTransferItemList.add() methods return the added item Have DataTransferItemList.add() methods return the added item to match the latest specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#datatransferitemlist DataTransferItemList is not implemented in Firefox 23 or IE10 yet. BUG=271424 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156094

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -57 lines) Patch
M LayoutTests/fast/events/drag-dataTransferItemList.html View 2 chunks +15 lines, -4 lines 0 comments Download
M LayoutTests/fast/events/drag-dataTransferItemList-expected.txt View 3 chunks +20 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/drag-dataTransferItemList-file-handling.html View 4 chunks +25 lines, -30 lines 0 comments Download
M LayoutTests/fast/events/drag-dataTransferItemList-file-handling-expected.txt View 1 chunk +16 lines, -4 lines 0 comments Download
M Source/core/dom/DataTransferItemList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DataTransferItemList.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/chromium/ChromiumDataObject.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/chromium/ChromiumDataObject.cpp View 1 chunk +11 lines, -5 lines 0 comments Download
M Source/core/platform/chromium/ClipboardChromium.cpp View 2 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-14 08:55:55 UTC) #1
haraken
LGTM. Needs an approval from an API owner.
7 years, 4 months ago (2013-08-14 09:05:33 UTC) #2
jochen (gone - plz use gerrit)
approval lgtm
7 years, 4 months ago (2013-08-14 11:56:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22837006/1
7 years, 4 months ago (2013-08-14 12:03:02 UTC) #4
commit-bot: I haz the power
Change committed as 156094
7 years, 4 months ago (2013-08-14 13:22:29 UTC) #5
arv (Not doing code reviews)
7 years, 4 months ago (2013-08-14 15:23:51 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698