content/browser/web_contents/navigation_controller_impl_unittest.cc - Issue 22837005: Add HTTP status code to navigation data structures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/navigation_controller_impl_unittest.cc

Issue 22837005: Add HTTP status code to navigation data structures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sessions/session_restore_browsertest.cc ('K') | « content/browser/web_contents/navigation_controller_impl.cc ('k') | content/browser/web_contents/navigation_entry_impl.h » ('j') | content/browser/web_contents/navigation_entry_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/navigation_controller_impl_unittest.cc

diff --git a/content/browser/web_contents/navigation_controller_impl_unittest.cc b/content/browser/web_contents/navigation_controller_impl_unittest.cc

index 7a0b03b2bf06d7f09b1feb1144aae0701201b645..8ef6b8bcec32897e1c67c4083e34c31394026644 100644

--- a/content/browser/web_contents/navigation_controller_impl_unittest.cc

+++ b/content/browser/web_contents/navigation_controller_impl_unittest.cc

@@ -355,8 +355,9 @@ TEST_F(NavigationControllerTest, LoadURL) {

EXPECT_FALSE(controller.CanGoForward());

EXPECT_EQ(contents()->GetMaxPageID(), -1);

- // The timestamp should not have been set yet.

+ // Neither the timestamp not the status code hould not have been set yet.

Nicolas Zea 2013/08/15 18:25:40 "nor the status code should have been"

pval...(no longer on Chromium) 2013/08/20 15:28:10 yikes. thanks for catching my error here.

EXPECT_TRUE(controller.GetPendingEntry()->GetTimestamp().is_null());

+ EXPECT_EQ(0, controller.GetPendingEntry()->GetHttpStatusCode());

// We should have gotten no notifications from the preceeding checks.

EXPECT_EQ(0U, notifications.size());