Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc

Issue 2283553002: Extend |is_type_trait_value| matcher to cover |blink| namespace. (Closed)
Patch Set: Self-review. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc b/tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc
index 58c9dc6724525f86ab7ad01bc439b936b47d4a42..a739b7dcb73c217669711b10f9620b13f4e2dd10 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc
@@ -65,6 +65,11 @@ union U {
int has_prefix_;
};
+// https://crbug.com/640749#c1: Some type traits are inside blink namespace.
+struct IsGarbageCollectedMixin {
+ static const bool value = true;
+};
+
} // namespace blink
namespace WTF {
@@ -75,7 +80,7 @@ struct TypeTrait1 {
static const bool value = true;
};
-// Some type traits are implemented as classes, not structs
+// Some type traits are implemented as classes, not structs
// (e.g. WTF::IsGarbageCollectedType or WTF::IsAssignable).
template <typename T>
class TypeTrait2 {

Powered by Google App Engine
This is Rietveld 408576698