[Cronet] JavaUrlRequest - Don't call close() on a user thread - it can do I/O.

components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import android.os.ConditionVariable;
+import android.os.StrictMode;
 import android.test.MoreAsserts;
 import android.test.suitebuilder.annotation.SmallTest;
 import android.util.Log;
 
 import org.chromium.base.test.util.Feature;
 import org.chromium.net.TestUrlRequestCallback.FailureType;
 import org.chromium.net.TestUrlRequestCallback.ResponseStep;
 import org.chromium.net.impl.CronetUrlRequest;
 import org.chromium.net.test.FailurePhase;
 
@@ skipping 803 matching lines @@
         callback.setAutoAdvance(true);
         ByteBuffer readBuffer = ByteBuffer.allocateDirect(5);
         urlRequest.read(readBuffer);
         callback.blockForDone();
         assertEquals(200, callback.mResponseInfo.getHttpStatusCode());
         assertEquals("GET", callback.mResponseAsString);
     }
 
     @SmallTest
     @Feature({"Cronet"})
+    public void testNoIoInCancel() throws Exception {
+        final TestUrlRequestCallback callback = new TestUrlRequestCallback();
+        callback.setAutoAdvance(false);
+        final UrlRequest urlRequest =
+                new UrlRequest
+                        .Builder(NativeTestServer.getEchoHeaderURL("blah-header"), callback,
+                                callback.getExecutor(), mTestFramework.mCronetEngine)
+                        .addHeader("blah-header", "blahblahblah")
+                        .build();
+        urlRequest.start();
+        callback.waitForNextStep();
+        callback.startNextRead(urlRequest, ByteBuffer.allocateDirect(4));
+        callback.waitForNextStep();
+        StrictMode.ThreadPolicy oldPolicy = StrictMode.getThreadPolicy();
+        StrictMode.setThreadPolicy(new StrictMode.ThreadPolicy.Builder()
+                                           .detectAll()
+                                           .penaltyDeath()
+                                           .penaltyLog()
+                                           .build());
+        try {
+            urlRequest.cancel();

[mef, 2016/08/25 22:23:54]

Do you need to setup something to trigger IO on cancel?

[Charles, 2016/08/26 15:58:19]

I do set up - this is in the middle of a request when I cancel. 

[mef, 2016/08/26 16:14:11]

Acknowledged.

+        } finally {
+            StrictMode.setThreadPolicy(oldPolicy);
+        }
+        callback.blockForDone();
+        assertEquals(true, callback.mOnCanceledCalled);
+    }
+
+    @SmallTest
+    @Feature({"Cronet"})
     public void testUnexpectedReads() throws Exception {
         final TestUrlRequestCallback callback = new TestUrlRequestCallback();
         callback.setAutoAdvance(false);
         final UrlRequest urlRequest =
                 new UrlRequest.Builder(NativeTestServer.getRedirectURL(), callback,
                                       callback.getExecutor(), mTestFramework.mCronetEngine)
                         .build();
 
         // Try to read before starting request.
         try {
@@ skipping 973 matching lines @@
     private String bufferContentsToString(ByteBuffer byteBuffer, int start, int end) {
         // Use a duplicate to avoid modifying byteBuffer.
         ByteBuffer duplicate = byteBuffer.duplicate();
         duplicate.position(start);
         duplicate.limit(end);
         byte[] contents = new byte[duplicate.remaining()];
         duplicate.get(contents);
         return new String(contents);
     }
 }