content/browser/loader/test_url_loader_client.cc - Issue 2283473002: Fixes for the failing URLLoaderFactoryImplTest content_unittests with PlzNavigate enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/test_url_loader_client.cc

Issue 2283473002: Fixes for the failing URLLoaderFactoryImplTest content_unittests with PlzNavigate enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | content/browser/loader/url_loader_factory_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/test_url_loader_client.cc

diff --git a/content/browser/loader/test_url_loader_client.cc b/content/browser/loader/test_url_loader_client.cc

index 2f7234fa3762b7a71fad302d1933ed61ffe7f69e..035a050d28a1bc73d118524dea052668d1de001d 100644

--- a/content/browser/loader/test_url_loader_client.cc

+++ b/content/browser/loader/test_url_loader_client.cc

@@ -51,6 +51,8 @@ void TestURLLoaderClient::RunUntilResponseReceived() {

}

void TestURLLoaderClient::RunUntilResponseBodyArrived() {

+ if (response_body_.is_valid())

+ return;

base::RunLoop run_loop;

quit_closure_for_on_start_loading_response_body_ = run_loop.QuitClosure();

run_loop.Run();

@@ -58,6 +60,8 @@ void TestURLLoaderClient::RunUntilResponseBodyArrived() {

}

void TestURLLoaderClient::RunUntilComplete() {

+ if (has_received_completion_)

+ return;

base::RunLoop run_loop;

quit_closure_for_on_complete_ = run_loop.QuitClosure();

run_loop.Run();