Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: content/browser/loader/url_loader_factory_impl_unittest.cc

Issue 2283473002: Fixes for the failing URLLoaderFactoryImplTest content_unittests with PlzNavigate enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment and fix bot redness Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/url_loader_factory_impl_unittest.cc
diff --git a/content/browser/loader/url_loader_factory_impl_unittest.cc b/content/browser/loader/url_loader_factory_impl_unittest.cc
index 70f48d69e5946b7e6ea9566f0978bbc93a9dd7be..47b9fe9a73294569eb3ff46ebe7ba3c247307cf5 100644
--- a/content/browser/loader/url_loader_factory_impl_unittest.cc
+++ b/content/browser/loader/url_loader_factory_impl_unittest.cc
@@ -29,6 +29,7 @@
#include "content/public/browser/resource_context.h"
#include "content/public/browser/resource_dispatcher_host_delegate.h"
#include "content/public/common/content_paths.h"
+#include "content/public/common/process_type.h"
#include "content/public/test/test_browser_context.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "mojo/public/c/system/data_pipe.h"
@@ -75,7 +76,12 @@ class URLLoaderFactoryImplTest : public ::testing::TestWithParam<size_t> {
browser_context_(new TestBrowserContext()),
resource_message_filter_(new ResourceMessageFilter(
0,
- 0,
+ // If browser side navigation is enabled then
+ // ResourceDispatcherHostImpl prevents main frame URL requests from
+ // the renderer. Ensure that these checks don't trip us up by
+ // setting the process type in ResourceMessageFilter as
+ // PROCESS_TYPE_UNKNOWN.
+ PROCESS_TYPE_UNKNOWN,
nullptr,
nullptr,
nullptr,

Powered by Google App Engine
This is Rietveld 408576698