Make LocalsHandler depend on GraphBuilder instead of SsaBuilder.

Make LocalsHandler depend on GraphBuilder instead of SsaBuilder.

This allows the KernelSsaBuilder to use LocalsHandler as well. I
noticed that there were some methods and fields in SsaBuilder that
were only used in the LocalsHandler, so I moved them into LocalsHandler
instead. I also moved LocalsHandler to its own file.

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/1ce914537452efc773f9be61b9f5e4a83dc4845f

[Harry Terkelsen, 2016-08-25 18:12:31]

het@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-08-25 19:12:53]

lgtm

https://codereview.chromium.org/2283443002/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2283443002/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:57: final ResolvedAst resolvedAst;
consider making a note that we only intend to use this for the source-info
builder?

https://codereview.chromium.org/2283443002/diff/1/pkg/compiler/lib/src/ssa/lo...
File pkg/compiler/lib/src/ssa/locals_handler.dart (right):

https://codereview.chromium.org/2283443002/diff/1/pkg/compiler/lib/src/ssa/lo...
pkg/compiler/lib/src/ssa/locals_handler.dart:22: /**
feel free to convert to /// comment style if you so desire... we can also do a
pass later to convert everything at once, I believe John had a script that did
that.

https://codereview.chromium.org/2283443002/diff/1/pkg/compiler/lib/src/ssa/lo...
pkg/compiler/lib/src/ssa/locals_handler.dart:136: void enterScope(ast.Node node,
Element element) {
one idea (feel free to defer for later): we could parameterize this class as
LocalsHandler<T> (probably closureData too), and replace T for ast.Node or
ir.Node depending on where we use it.

Or create a map [Node -> ScopeId] that is separate from these classes, and only
use ScopeIds here...

[Harry Terkelsen, 2016-08-25 20:12:57]

https://codereview.chromium.org/2283443002/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2283443002/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:57: final ResolvedAst resolvedAst;
On 2016/08/25 19:12:53, Siggi Cherem (dart-lang) wrote:
> consider making a note that we only intend to use this for the source-info
> builder? 

It's also used later for the locals handler in
'localsHandler.startFunction(...)'

https://codereview.chromium.org/2283443002/diff/1/pkg/compiler/lib/src/ssa/lo...
File pkg/compiler/lib/src/ssa/locals_handler.dart (right):

https://codereview.chromium.org/2283443002/diff/1/pkg/compiler/lib/src/ssa/lo...
pkg/compiler/lib/src/ssa/locals_handler.dart:22: /**
On 2016/08/25 19:12:53, Siggi Cherem (dart-lang) wrote:
> feel free to convert to /// comment style if you so desire... we can also do a
> pass later to convert everything at once, I believe John had a script that did
> that.

Done.

https://codereview.chromium.org/2283443002/diff/1/pkg/compiler/lib/src/ssa/lo...
pkg/compiler/lib/src/ssa/locals_handler.dart:136: void enterScope(ast.Node node,
Element element) {
On 2016/08/25 19:12:53, Siggi Cherem (dart-lang) wrote:
> one idea (feel free to defer for later): we could parameterize this class as
> LocalsHandler<T> (probably closureData too), and replace T for ast.Node or
> ir.Node depending on where we use it.
> 
> Or create a map [Node -> ScopeId] that is separate from these classes, and
only
> use ScopeIds here...

Acknowledged.

[Harry Terkelsen, 2016-08-25 20:25:57]

Description was changed from

==========
Make LocalsHandler depend on GraphBuilder instead of SsaBuilder.

This allows the KernelSsaBuilder to use LocalsHandler as well. I
noticed that there were some methods and fields in SsaBuilder that
were only used in the LocalsHandler, so I moved them into LocalsHandler
instead. I also moved LocalsHandler to its own file.

BUG=
==========

to

==========
Make LocalsHandler depend on GraphBuilder instead of SsaBuilder.

This allows the KernelSsaBuilder to use LocalsHandler as well. I
noticed that there were some methods and fields in SsaBuilder that
were only used in the LocalsHandler, so I moved them into LocalsHandler
instead. I also moved LocalsHandler to its own file.

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1ce914537452efc773f9be61b9f5e4a83dc4845f
==========

[Harry Terkelsen, 2016-08-25 20:25:59]

Committed patchset #2 (id:20001) manually as
1ce914537452efc773f9be61b9f5e4a83dc4845f (presubmit successful).