Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 228343003: More removal of duplicate framework defines. (Closed)

Created:
6 years, 8 months ago by scroggo
Modified:
6 years, 8 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

More removal of duplicate framework defines. BUG=skia:1975 Committed: http://code.google.com/p/skia/source/detail?r=14174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
Nvm my last comment, removing these does the right thing.
6 years, 8 months ago (2014-04-11 20:38:41 UTC) #1
djsollen
lgtm
6 years, 8 months ago (2014-04-11 20:42:28 UTC) #2
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 8 months ago (2014-04-11 20:44:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/228343003/1
6 years, 8 months ago (2014-04-11 20:44:14 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 14:54:03 UTC) #5
Message was sent while issue was closed. 
Change committed as 14174

Powered by Google App Engine
This is Rietveld 408576698