Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 2283413003: Copy float list of ruby base when merging it with a sibling (Closed)

Created:
4 years, 3 months ago by rhogan
Modified:
4 years, 3 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Copy float list of ruby base when merging it with a sibling When merging two ruby bases ensure that the new base has a complete float list. BUG=619380, 624028 Committed: https://crrev.com/6f208d569f6bd2488f2f2f6f9004e54417f78782 Cr-Commit-Position: refs/heads/master@{#415337}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -31 lines) Patch
M third_party/WebKit/LayoutTests/fast/block/float/float-reparent-during-detach-crash.html View 1 chunk +16 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.cpp View 3 chunks +3 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
rhogan
4 years, 3 months ago (2016-08-30 15:05:58 UTC) #7
eae
This is great, thank you! LGTM
4 years, 3 months ago (2016-08-30 15:18:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283413003/1
4 years, 3 months ago (2016-08-30 17:26:13 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 17:31:17 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6f208d569f6bd2488f2f2f6f9004e54417f78782 Cr-Commit-Position: refs/heads/master@{#415337}
4 years, 3 months ago (2016-08-30 17:34:55 UTC) #13
Will Harris
4 years, 3 months ago (2016-09-07 21:13:49 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2322703002/ by wfh@chromium.org.

The reason for reverting is: see crbug.com/644605.

Powered by Google App Engine
This is Rietveld 408576698