Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2283393002: Use a field trial to decide if QUIC should attempt to prevent packet fragmentation. (Closed)

Created:
4 years, 3 months ago by Ryan Hamilton
Modified:
4 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a field trial to decide if QUIC should attempt to prevent packet fragmentation. BUG=641791 Committed: https://crrev.com/bedd5745be79b6a15b1d5f6212411d5d7484b11e Cr-Commit-Position: refs/heads/master@{#415385}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : fix #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -6 lines) Patch
M components/network_session_configurator/network_session_configurator.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M components/network_session_configurator/network_session_configurator_unittest.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/http/http_network_session.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 1 2 3 3 chunks +9 lines, -5 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 34 (23 generated)
Ryan Hamilton
4 years, 3 months ago (2016-08-28 20:35:51 UTC) #3
Ryan Hamilton
jri/ianswett: PTAL
4 years, 3 months ago (2016-08-28 23:25:55 UTC) #14
Jeremy Dorfman
On 2016/08/28 23:25:55, Ryan Hamilton wrote: > jri/ianswett: PTAL LGTM.
4 years, 3 months ago (2016-08-28 23:32:21 UTC) #15
ianswett
lgtm
4 years, 3 months ago (2016-08-29 01:12:36 UTC) #19
Jana
lgtm
4 years, 3 months ago (2016-08-29 16:52:34 UTC) #20
commit-bot: I haz the power
This CL has an open dependency (Issue 2287073002 Patch 1). Please resolve the dependency and ...
4 years, 3 months ago (2016-08-29 17:50:37 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283393002/60001
4 years, 3 months ago (2016-08-30 00:29:02 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/287019)
4 years, 3 months ago (2016-08-30 03:39:38 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283393002/60001
4 years, 3 months ago (2016-08-30 17:42:54 UTC) #30
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-30 19:12:14 UTC) #32
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 19:15:36 UTC) #34
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bedd5745be79b6a15b1d5f6212411d5d7484b11e
Cr-Commit-Position: refs/heads/master@{#415385}

Powered by Google App Engine
This is Rietveld 408576698