Attempt the elevated path for the rename dance first for per-machine installs.

Attempt the elevated path for the rename dance first for per-machine installs.

This will eliminate some wasted cycles during the rename dance for the
majority of installs, thereby leading to a better update experience for
users.

Also included in this change: removed some duplicated code and fixed up
use of the registry. More on the latter: all integration points between
Chrome and Google Update unconditionally take place in the 32-bit view
of the Windows registry. As such, we use KEY_WOW64_32KEY everywhere even
when it isn't strictly needed. It seems that this spot was missed during
the great 64-bit-ification of Chrome. It just so happens that it's
harmless for per-user installs since HKCU\Software is not redirected for
64-bit apps in the way that HKLM\Software is.

BUG=610305
R=brucedawson@chromium.org

Committed: https://crrev.com/b35a90bd1b901860dbc8db106649f207c60690e2
Cr-Commit-Position: refs/heads/master@{#415163}

[grt (UTC plus 2), 2016-08-29 11:37:41]

PTAL. Please feel at liberty to check the CQ box if it looks good to you.
Thanks.

[grt (UTC plus 2), 2016-08-29 11:37:49]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 11:38:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 12:18:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 12:18:46]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2016-08-29 19:22:02]

In addition to the described changes this makes use of IsUpdatePendingRestart()
to avoid code duplication and adds  | KEY_WOW64_32KEY to the registry access.

The first change looks like a NOP and is good, but deserves description.
The second change I don't know the consequences of - can you mention that in the
description also?

[grt (UTC plus 2), 2016-08-29 20:11:40]

Description was changed from

==========
Attempt the elevated path for the rename dance first for per-machine installs.

This will eliminate some wasted cycles during the rename dance for the
majority of installs, thereby leading to a better update experience for
users.

BUG=610305
R=brucedawson@chromium.org
==========

to

==========
Attempt the elevated path for the rename dance first for per-machine installs.

This will eliminate some wasted cycles during the rename dance for the
majority of installs, thereby leading to a better update experience for
users.

Also included in this change: removed some duplicated code and fixed up
use of the registry. More on the latter: all integration points between
Chrome and Google Update unconditionally take place in the 32-bit view
of the Windows registry. As such, we use KEY_WOW64_32KEY everywhere even
when it isn't strictly needed. It seems that this spot was missed during
the great 64-bit-ification of Chrome. It just so happens that it's
harmless for per-user installs since HKCU\Software is not redirected for
64-bit apps in the way that HKLM\Software is.

BUG=610305
R=brucedawson@chromium.org
==========

[grt (UTC plus 2), 2016-08-29 20:12:16]

You betcha. PTAL and CQ if ya likes.

[brucedawson, 2016-08-29 20:25:31]

lgtm

[brucedawson, 2016-08-29 20:25:36]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-08-29 20:49:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2016-08-30 04:49:34]

The CQ bit was unchecked by grt@chromium.org

[grt (UTC plus 2), 2016-08-30 04:49:40]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2016-08-30 05:34:38]

Description was changed from

==========
Attempt the elevated path for the rename dance first for per-machine installs.

This will eliminate some wasted cycles during the rename dance for the
majority of installs, thereby leading to a better update experience for
users.

Also included in this change: removed some duplicated code and fixed up
use of the registry. More on the latter: all integration points between
Chrome and Google Update unconditionally take place in the 32-bit view
of the Windows registry. As such, we use KEY_WOW64_32KEY everywhere even
when it isn't strictly needed. It seems that this spot was missed during
the great 64-bit-ification of Chrome. It just so happens that it's
harmless for per-user installs since HKCU\Software is not redirected for
64-bit apps in the way that HKLM\Software is.

BUG=610305
R=brucedawson@chromium.org
==========

to

==========
Attempt the elevated path for the rename dance first for per-machine installs.

This will eliminate some wasted cycles during the rename dance for the
majority of installs, thereby leading to a better update experience for
users.

Also included in this change: removed some duplicated code and fixed up
use of the registry. More on the latter: all integration points between
Chrome and Google Update unconditionally take place in the 32-bit view
of the Windows registry. As such, we use KEY_WOW64_32KEY everywhere even
when it isn't strictly needed. It seems that this spot was missed during
the great 64-bit-ification of Chrome. It just so happens that it's
harmless for per-user installs since HKCU\Software is not redirected for
64-bit apps in the way that HKLM\Software is.

BUG=610305
R=brucedawson@chromium.org
==========

[commit-bot: I haz the power, 2016-08-30 05:34:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-30 05:38:24]

Description was changed from

==========
Attempt the elevated path for the rename dance first for per-machine installs.

This will eliminate some wasted cycles during the rename dance for the
majority of installs, thereby leading to a better update experience for
users.

Also included in this change: removed some duplicated code and fixed up
use of the registry. More on the latter: all integration points between
Chrome and Google Update unconditionally take place in the 32-bit view
of the Windows registry. As such, we use KEY_WOW64_32KEY everywhere even
when it isn't strictly needed. It seems that this spot was missed during
the great 64-bit-ification of Chrome. It just so happens that it's
harmless for per-user installs since HKCU\Software is not redirected for
64-bit apps in the way that HKLM\Software is.

BUG=610305
R=brucedawson@chromium.org
==========

to

==========
Attempt the elevated path for the rename dance first for per-machine installs.

This will eliminate some wasted cycles during the rename dance for the
majority of installs, thereby leading to a better update experience for
users.

Also included in this change: removed some duplicated code and fixed up
use of the registry. More on the latter: all integration points between
Chrome and Google Update unconditionally take place in the 32-bit view
of the Windows registry. As such, we use KEY_WOW64_32KEY everywhere even
when it isn't strictly needed. It seems that this spot was missed during
the great 64-bit-ification of Chrome. It just so happens that it's
harmless for per-user installs since HKCU\Software is not redirected for
64-bit apps in the way that HKLM\Software is.

BUG=610305
R=brucedawson@chromium.org

Committed: https://crrev.com/b35a90bd1b901860dbc8db106649f207c60690e2
Cr-Commit-Position: refs/heads/master@{#415163}
==========

[commit-bot: I haz the power, 2016-08-30 05:38:25]

Patchset 1 (id:??) landed as
https://crrev.com/b35a90bd1b901860dbc8db106649f207c60690e2
Cr-Commit-Position: refs/heads/master@{#415163}