Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl

Issue 2283363003: GeometryInterface: Add DOMMatrixInit and fromMatrix(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl
diff --git a/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl b/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl
index 2051403533645fe694c8cf637fbbd818b80049f5..472fa33b1b9a5fd9b4b3d465adaf69de6a79a6fd 100644
--- a/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl
+++ b/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl
@@ -12,6 +12,7 @@
] interface DOMMatrixReadOnly {
[RaisesException, NewObject] static DOMMatrixReadOnly fromFloat32Array(Float32Array array32);
[RaisesException, NewObject] static DOMMatrixReadOnly fromFloat64Array(Float64Array array64);
+ [RaisesException, NewObject] static DOMMatrixReadOnly fromMatrix(optional DOMMatrixInit other);
// These attributes are simple aliases for certain elements of the 4x4 matrix
readonly attribute unrestricted double a;
@@ -41,7 +42,11 @@
readonly attribute boolean is2D;
readonly attribute boolean isIdentity;
- // FIXME: Should implement some methods (See: crbug.com/388780)
+ // TODO(zino): Should implement rotate() method (See: crbug.com/645878)
+ // TODO(zino): Should implement rotateFromVector() method (See: crbug.com/645882)
+ // TODO(zino): Should implement rotateAxisAngle() method (See: crbug.com/645883)
+ // TODO(zino): Should implement transformPoint() method (See: crbug.com/645885)
+ // TODO(zino): Should remove scaleNonUniform() method (See: crbug.com/645887)
// Immutable transform methods
DOMMatrix translate(unrestricted double tx,
unrestricted double ty,
@@ -59,9 +64,9 @@
optional unrestricted double originX = 0,
optional unrestricted double originY = 0,
optional unrestricted double originZ = 0);
- DOMMatrix multiply(DOMMatrix other);
DOMMatrix skewX(optional unrestricted double sx = 0);
DOMMatrix skewY(optional unrestricted double sy = 0);
+ [RaisesException] DOMMatrix multiply(optional DOMMatrixInit other);
DOMMatrix flipX();
DOMMatrix flipY();
DOMMatrix inverse();

Powered by Google App Engine
This is Rietveld 408576698