third_party/WebKit/Source/core/dom/DOMMatrix.idl - Issue 2283363003: GeometryInterface: Add DOMMatrixInit and fromMatrix().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DOMMatrix.idl

Issue 2283363003: GeometryInterface: Add DOMMatrixInit and fromMatrix(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/DOMMatrix.cpp ('k') | third_party/WebKit/Source/core/dom/DOMMatrixInit.idl » ('j') | third_party/WebKit/Source/core/dom/DOMMatrixTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/DOMMatrix.idl

diff --git a/third_party/WebKit/Source/core/dom/DOMMatrix.idl b/third_party/WebKit/Source/core/dom/DOMMatrix.idl

index 3d476ae76c709c54f1e55b76ff17c9f5d507a21b..db22f97daf1c6a6281c75178503eab5502141c61 100644

--- a/third_party/WebKit/Source/core/dom/DOMMatrix.idl

+++ b/third_party/WebKit/Source/core/dom/DOMMatrix.idl

@@ -13,6 +13,7 @@

] interface DOMMatrix : DOMMatrixReadOnly {

[RaisesException, NewObject] static DOMMatrix fromFloat32Array(Float32Array array32);

[RaisesException, NewObject] static DOMMatrix fromFloat64Array(Float64Array array64);

+ [RaisesException, NewObject] static DOMMatrix fromMatrix(optional DOMMatrixInit other);

// These attributes are simple aliases for certain elements of the 4x4 matrix

inherit attribute unrestricted double a;

@@ -39,10 +40,14 @@

inherit attribute unrestricted double m43;

inherit attribute unrestricted double m44;

- // FIXME: Should implement some methods (See: crbug.com/388780)

+ // TODO(zino): Should implement rotateSelf() method (See: crbug.com/645878)

+ // TODO(zino): Should implement rotateFromVectorSelf() method (See: crbug.com/645882)

+ // TODO(zino): Should implement rotateAxisAngleSelf() method (See: crbug.com/645883)

+ // TODO(zino): Should implement setMatrixValue() method (See: crbug.com/645884)

+ // TODO(zino): Should remove scaleNonUniformSelf() method (See: crbug.com/645887)

// Mutable transform methods

- DOMMatrix multiplySelf(DOMMatrix other);

- DOMMatrix preMultiplySelf(DOMMatrix other);

+ [RaisesException] DOMMatrix multiplySelf(optional DOMMatrixInit other);

+ [RaisesException] DOMMatrix preMultiplySelf(optional DOMMatrixInit other);

DOMMatrix translateSelf(unrestricted double tx,

unrestricted double ty,

optional unrestricted double tz = 0);