GeometryInterface: Add DOMMatrixInit and fromMatrix().

third_party/WebKit/Source/core/dom/DOMMatrix.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/DOMMatrix.h"
 
 namespace blink {
 
 DOMMatrix* DOMMatrix::create()
 {
@@ skipping 10 matching lines @@
     TransformationMatrix transformationMatrix(matrix);
     return new DOMMatrix(transformationMatrix, transformationMatrix.isAffine());
 }
 
 DOMMatrix::DOMMatrix(const TransformationMatrix& matrix, bool is2D)
 {
     m_matrix = TransformationMatrix::create(matrix);
     m_is2D = is2D;
 }
 
+DOMMatrix* DOMMatrix::fromMatrix(DOMMatrixInit& other, ExceptionState& exceptionState)
+{
+    validateAndFixup(other, exceptionState);
+    if (exceptionState.hadException())
+        return nullptr;
+
+    if (other.is2D()) {
+        return new DOMMatrix({
+            other.m11(), other.m12(), other.m21(),
+            other.m22(), other.m41(), other.m42()}, other.is2D());
+    }
+
+    return new DOMMatrix({
+        other.m11(), other.m12(), other.m13(), other.m14(),
+        other.m21(), other.m22(), other.m23(), other.m24(),
+        other.m31(), other.m32(), other.m33(), other.m34(),
+        other.m41(), other.m42(), other.m43(), other.m44()}, other.is2D());
+}
+
 void DOMMatrix::setIs2D(bool value)
 {
     if (m_is2D)
         m_is2D = value;
 }
 
-DOMMatrix* DOMMatrix::multiplySelf(DOMMatrix* other)
+DOMMatrix* DOMMatrix::multiplySelf(DOMMatrixInit& other, ExceptionState& exceptionState)
 {
-    if (!other->is2D())
+    DOMMatrix* otherMatrix = DOMMatrix::fromMatrix(other, exceptionState);
+    if (!otherMatrix->is2D())

[dominicc (has gone to gerrit), 2016/08/30 02:13:43]

Seems a shame to allocate the whole intermediate DOMMatrix, but then the spec
warns authors about that, so I guess this way is at least clean and simple.

[zino, 2016/09/10 10:18:15]

I'll try to file a bug.

         m_is2D = false;
 
-    *m_matrix *= other->matrix();
+    *m_matrix *= otherMatrix->matrix();
 
     return this;
 }
 
-DOMMatrix* DOMMatrix::preMultiplySelf(DOMMatrix* other)
+DOMMatrix* DOMMatrix::preMultiplySelf(DOMMatrixInit& other, ExceptionState& exceptionState)
 {
-    if (!other->is2D())
+    DOMMatrix* otherMatrix = DOMMatrix::fromMatrix(other, exceptionState);
+    if (!otherMatrix->is2D())
         m_is2D = false;
 
     TransformationMatrix& matrix = *m_matrix;
-    *m_matrix = other->matrix() * matrix;
+    *m_matrix = otherMatrix->matrix() * matrix;
 
     return this;
 }
 
 DOMMatrix* DOMMatrix::translateSelf(double tx, double ty, double tz)
 {
     if (!tx && !ty && !tz)
         return this;
 
     if (tz)
@@ skipping 48 matching lines @@
     return this;
 }
 
 DOMMatrix* DOMMatrix::skewYSelf(double sy)
 {
     m_matrix->skewY(sy);
     return this;
 }
 
 } // namespace blink