Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2283263002: Converted Observatory script-view element (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index 365690773ab36fb3fc8e650230bb2f18b992bff1..437d657fd637ace1afcd244cd8f30c90ef574d71 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -22,6 +22,7 @@ ObjectStoreRepository _objectstoreRepository
PersistentHandlesRepository _persistentHandlesRepository
= new PersistentHandlesRepository();
PortsRepository _portsRepository = new PortsRepository();
+ScriptRepository _scriptRepository = new ScriptRepository();
class IsolateNotFound implements Exception {
String isolateId;
@@ -228,6 +229,24 @@ class InspectPage extends MatchingPage {
_instanceRepository,
queue: app.queue)
];
+ } else if (obj is Script) {
+ var pos;
+ if (app.locationManager.internalArguments['pos'] != null) {
+ try {
+ pos = int.parse(app.locationManager.internalArguments['pos']);
+ } catch (_) {}
+ }
+ container.children = [
+ new ScriptViewElement(app.vm, obj.isolate, obj, app.events,
+ app.notifications,
+ _scriptRepository,
+ _retainedSizeRepository,
+ _reachableSizeRepository,
+ _inboundReferencesRepository,
+ _retainingPathRepository,
+ _instanceRepository,
+ pos: pos, queue: app.queue)
+ ];
} else {
ServiceObjectViewElement serviceElement =new Element.tag('service-view');
serviceElement.object = obj;

Powered by Google App Engine
This is Rietveld 408576698