Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2283263002: Converted Observatory script-view element (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge, rmacnak, Cutch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed script-inset font #

Patch Set 3 : Fixed page title #

Patch Set 4 : Removed dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -62 lines) Patch
M runtime/observatory/lib/elements.dart View 1 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 1 chunk +18 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 3 chunks +8 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_inset_wrapper.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/script_view.dart View 1 2 3 1 chunk +152 lines, -11 lines 0 comments Download
D runtime/observatory/lib/src/elements/script_view.html View 1 chunk +0 lines, -38 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/source_inset_wrapper.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
cbernaschina
4 years, 3 months ago (2016-08-27 01:06:07 UTC) #2
rmacnak
The script view loads with the browser's default font instead of the font we use ...
4 years, 3 months ago (2016-08-29 17:35:29 UTC) #3
cbernaschina
Fixed CSS style. The * rule was too intrusive, using default inheritance instead https://codereview.chromium.org/2283263002/diff/1/runtime/observatory/lib/src/elements/script_view.dart File ...
4 years, 3 months ago (2016-08-29 18:06:38 UTC) #4
rmacnak
lgtm
4 years, 3 months ago (2016-08-29 20:19:47 UTC) #5
cbernaschina
4 years, 3 months ago (2016-08-29 20:34:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
3b16691da147f6c76d0101754a9e8e8f330d427b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698