components/cronet/android/test/javatests/src/org/chromium/net/TestUploadDataProvider.java - Issue 2283243002: Allow direct executors in cronet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/TestUploadDataProvider.java

Issue 2283243002: Allow direct executors in cronet. (Closed)

Patch Set: Refactor DirectPreventingExecutor, and fix closing logic Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java ('K') | « components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/TestUploadDataProvider.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/TestUploadDataProvider.java b/components/cronet/android/test/javatests/src/org/chromium/net/TestUploadDataProvider.java

index b7046202d50035c557bcee10b105fa81c2169021..c85faa31fccd4bc03936f827cd00ae198342a563 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/TestUploadDataProvider.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/TestUploadDataProvider.java

@@ -279,7 +279,7 @@ class TestUploadDataProvider extends UploadDataProvider {

}

public void assertClosed() {

- mAwaitingClose.block();

+ mAwaitingClose.block(5000);

if (!mClosed.get()) {

throw new AssertionError("Was not closed");

}