Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: components/cronet/android/cronet_url_request_adapter.cc

Issue 2283243002: Allow direct executors in cronet. (Closed)
Patch Set: Improve thread checking Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/cronet_url_request_adapter.cc
diff --git a/components/cronet/android/cronet_url_request_adapter.cc b/components/cronet/android/cronet_url_request_adapter.cc
index 2e7d84dc3e4a90b379145e14e17fa933c259bc46..cb021c5411e271309e4726888c505be08ce80004 100644
--- a/components/cronet/android/cronet_url_request_adapter.cc
+++ b/components/cronet/android/cronet_url_request_adapter.cc
@@ -136,7 +136,6 @@ void CronetURLRequestAdapter::GetStatus(
JNIEnv* env,
const JavaParamRef<jobject>& jcaller,
const JavaParamRef<jobject>& jstatus_listener) const {
- DCHECK(!context_->IsOnNetworkThread());
base::android::ScopedJavaGlobalRef<jobject> status_listener_ref;
status_listener_ref.Reset(env, jstatus_listener);
context_->PostTaskToNetworkThread(
@@ -147,7 +146,6 @@ void CronetURLRequestAdapter::GetStatus(
void CronetURLRequestAdapter::FollowDeferredRedirect(
JNIEnv* env,
const JavaParamRef<jobject>& jcaller) {
- DCHECK(!context_->IsOnNetworkThread());
context_->PostTaskToNetworkThread(
FROM_HERE,
base::Bind(
@@ -161,7 +159,6 @@ jboolean CronetURLRequestAdapter::ReadData(
const JavaParamRef<jobject>& jbyte_buffer,
jint jposition,
jint jlimit) {
- DCHECK(!context_->IsOnNetworkThread());
DCHECK_LT(jposition, jlimit);
void* data = env->GetDirectBufferAddress(jbyte_buffer);

Powered by Google App Engine
This is Rietveld 408576698