Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: components/cronet/android/api/src/org/chromium/net/CronetEngine.java

Issue 2283243002: Allow direct executors in cronet. (Closed)
Patch Set: Improve thread checking Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/api/src/org/chromium/net/CronetEngine.java
diff --git a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
index a1e9b0493e810bd72125781d582f55534a8228d4..a94dcb15eb18a7e4b521dc5a5a9554ce63f1eb55 100644
--- a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
+++ b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
@@ -827,7 +827,7 @@ public abstract class CronetEngine {
public final UrlRequest createRequest(String url, UrlRequest.Callback callback,
Executor executor, @UrlRequest.Builder.RequestPriority int priority) {
return createRequest(
- url, callback, executor, priority, Collections.emptyList(), false, false);
+ url, callback, executor, priority, Collections.emptyList(), false, false, false);
}
/**
@@ -847,6 +847,8 @@ public abstract class CronetEngine {
* If context is not set up to use cache this param has no effect.
* @param disableConnectionMigration disables connection migration for this
* request if it is enabled for the session.
+ * @param allowDirectExecutor whether executors used by this request are permitted
+ * to execute submitted tasks inline.
* @return new request.
* @deprecated Use {@link UrlRequest.Builder#build}.
* @hide as it references hidden RequestFinishedInfo.Listener
@@ -854,7 +856,7 @@ public abstract class CronetEngine {
@Deprecated
protected abstract UrlRequest createRequest(String url, UrlRequest.Callback callback,
Executor executor, int priority, Collection<Object> requestAnnotations,
- boolean disableCache, boolean disableConnectionMigration);
+ boolean disableCache, boolean disableConnectionMigration, boolean allowDirectExecutor);
/**
* Creates a {@link BidirectionalStream} object. {@code callback} methods will

Powered by Google App Engine
This is Rietveld 408576698