components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java - Issue 2283243002: Allow direct executors in cronet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java

Issue 2283243002: Allow direct executors in cronet. (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/api/src/org/chromium/net/InlineExecutionProhibitedException.java ('K') | « components/cronet/android/api/src/org/chromium/net/InlineExecutionProhibitedException.java ('k') | components/cronet/android/api/src/org/chromium/net/JavaUrlRequest.java » ('j') | components/cronet/android/api/src/org/chromium/net/JavaUrlRequest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java

diff --git a/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java b/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java

index 1f7b75e7aa72290d8bb63c272e50f85121e5e669..711aa6681d69dbde9ee72006addca7120ca2ec46 100644

--- a/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java

+++ b/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java

@@ -58,8 +58,9 @@ final class JavaCronetEngine extends CronetEngine {

@Override

public UrlRequest createRequest(String url, UrlRequest.Callback callback, Executor executor,

int priority, Collection<Object> connectionAnnotations, boolean disableCache,

- boolean disableConnectionMigration) {

- return new JavaUrlRequest(callback, mExecutorService, executor, url, mUserAgent);

+ boolean disableConnectionMigration, boolean allowDirectExecutor) {

+ return new JavaUrlRequest(

+ callback, mExecutorService, executor, url, mUserAgent, allowDirectExecutor);

}

@Override